chore: remove unique_calendar_ids

the unique_calendar_ids old compatibility flag seems not to be needed anymore by any servers I test.

Author: tobixen

caldav/compatibility_hints.py

@@ -77,6 +77,9 @@ class FeatureSet:
                 ## TODO: in the future, templates for the principal URL, calendar URLs etc may also be added.
             }
         },
+        "url": {
+            "type": "client-hints",
+        },
         "get-current-user-principal": {
             "description": "Support for RFC5397, current principal extension.  Most CalDAV servers have this, but it is an extension to the DAV standard.  Possibly observed missing on mail.ru, DavMail gateway and it is possible to configure the support in some sabre-based servers",
             "links": ["https://datatracker.ietf.org/doc/html/rfc5397"],
@@ -859,9 +862,6 @@ def dotted_feature_set_list(self, compact=False):
     'vtodo-cannot-be-uncompleted':
         """If a VTODO object has been set with STATUS:COMPLETE, it's not possible to delete the COMPLTEDED attribute and change back to STATUS:IN-ACTION""",
 
-    'unique_calendar_ids':
-        """For every test, generate a new and unique calendar id""",
-
     'sticky_events':
         """Events should be deleted before the calendar is deleted, """
         """and/or deleting a calendar may not have immediate effect""",
@@ -965,7 +965,6 @@ def dotted_feature_set_list(self, compact=False):
     'principal-search.by-name.self': {'support': 'unsupported'},
     'principal-search': {'support': 'ungraceful'},
     'search.time-range.open.start.duration': 'broken',
-    #'old_flags': ['unique_calendar_ids'],
     ## I'm surprised, I'm quite sure this was passing earlier.  Caldav commit a98d50490b872e9b9d8e93e2e401c936ad193003, caldav server checker commit 3cae24cf99da1702b851b5a74a9b88c8e5317dad
     'search.combined-is-logical-and': False,
     ## Observed with Nextcloud 33: server delivers iTIP notification to the inbox AND
@@ -997,7 +996,9 @@ def dotted_feature_set_list(self, compact=False):
 zimbra = {
     'auto-connect.url': {'basepath': '/dav/'},
     'delete-calendar': {'support': 'fragile', 'behaviour': 'may move to trashbin instead of deleting immediately'},
-    'save-load.get-by-url': {'support': 'fragile', 'behaviour': '404 most of the time - but sometimes 200.  Weird, should be investigated more'},
+    ## This is a zimbra bug when creating calendars with a display
+    ## name.  Now mitigated in the calendar creation code.
+    #'save-load.get-by-url': {'support': 'fragile', 'behaviour': '404 most of the time - but sometimes 200.  Weird, should be investigated more'},
     ## Zimbra treats same-UID events across calendars as aliases of the same event
     'save.duplicate-uid.cross-calendar': {'support': 'unsupported'},
     'search.recurrences.expanded.exception': {'support': 'unsupported'}, ## TODO: verify
@@ -1160,7 +1161,6 @@ def dotted_feature_set_list(self, compact=False):
 
 ## See comments on https://github.com/python-caldav/caldav/issues/3
 #icloud = [
-#    'unique_calendar_ids',
 #    'duplicate_in_other_calendar_with_same_uid_breaks',
 #    'sticky_events',
 #    'no_journal', ## it threw a 500 internal server error!

tests/test_caldav.py

@@ -1322,12 +1322,8 @@ def setup_method(self):
         for flag in self.old_features:
             assert flag in incompatibility_description
 
-        if self.check_compatibility_flag("unique_calendar_ids"):
-            self.testcal_id = "testcalendar-" + str(uuid.uuid4())
-            self.testcal_id2 = "testcalendar-" + str(uuid.uuid4())
-        else:
-            self.testcal_id = "pythoncaldav-test"
-            self.testcal_id2 = "pythoncaldav-test2"
+        self.testcal_id = "pythoncaldav-test"
+        self.testcal_id2 = "pythoncaldav-test2"
 
         foo = self.is_supported("rate-limit", dict)
         if foo.get("enable"):
@@ -1408,8 +1404,6 @@ def _cleanup(self, mode=None):
                     pass
             else:
                 cal.delete()
-        if self.check_compatibility_flag("unique_calendar_ids") and mode == "pre":
-            a = self._teardownCalendar(name="Yep")
         for calid in (self.testcal_id, self.testcal_id2, self.testcal_id + "-tasks"):
             self._teardownCalendar(cal_id=calid)
         if self.cleanup_regime == "thorough":
@@ -1471,10 +1465,7 @@ def _fixCalendar_(self, **kwargs):
 
         # Pre-processing: set up defaults for name and cal_id
         if "name" not in kwargs:
-            if not self.check_compatibility_flag("unique_calendar_ids") and self.cleanup_regime in (
-                "light",
-                "pre",
-            ):
+            if self.cleanup_regime in ("light", "pre"):
                 self._teardownCalendar(cal_id=self.testcal_id)
             if not self.is_supported("create-calendar.set-displayname"):
                 kwargs["name"] = None
@@ -2291,10 +2282,7 @@ def testSync(self):
     def testLoadEvent(self):
         self.skip_unless_support("save-load.event")
         self.skip_unless_support("create-calendar")
-        if not self.check_compatibility_flag("unique_calendar_ids") and self.cleanup_regime in (
-            "light",
-            "pre",
-        ):
+        if self.cleanup_regime in ("light", "pre"):
             self._teardownCalendar(cal_id=self.testcal_id)
             self._teardownCalendar(cal_id=self.testcal_id2)
         c1 = self._fixCalendar(name="Yep", cal_id=self.testcal_id)
@@ -2307,20 +2295,14 @@ def testLoadEvent(self):
         if not self.check_compatibility_flag("event_by_url_is_broken"):
             assert e1.url == e1_.url
             e1.load()
-        if (
-            not self.check_compatibility_flag("unique_calendar_ids")
-            and self.cleanup_regime == "post"
-        ):
+        if self.cleanup_regime == "post":
             self._teardownCalendar(cal_id=self.testcal_id)
             self._teardownCalendar(cal_id=self.testcal_id2)
 
     def testCopyEvent(self):
         self.skip_unless_support("save-load.event")
         self.skip_unless_support("create-calendar")
-        if not self.check_compatibility_flag("unique_calendar_ids") and self.cleanup_regime in (
-            "light",
-            "pre",
-        ):
+        if self.cleanup_regime in ("light", "pre"):
             self._teardownCalendar(cal_id=self.testcal_id)
             self._teardownCalendar(cal_id=self.testcal_id2)
 
@@ -2366,10 +2348,7 @@ def testCopyEvent(self):
         else:
             assert len(c1.get_events()) == 2
 
-        if (
-            not self.check_compatibility_flag("unique_calendar_ids")
-            and self.cleanup_regime == "post"
-        ):
+        if self.cleanup_regime == "post":
             self._teardownCalendar(cal_id=self.testcal_id)
             self._teardownCalendar(cal_id=self.testcal_id2)
 
@@ -3496,10 +3475,7 @@ def testUtf8Event(self):
         # TODO: split up in creating a calendar with non-ascii name
         # and an event with non-ascii description
         self.skip_unless_support("create-calendar")
-        if not self.check_compatibility_flag("unique_calendar_ids") and self.cleanup_regime in (
-            "light",
-            "pre",
-        ):
+        if self.cleanup_regime in ("light", "pre"):
             self._teardownCalendar(cal_id=self.testcal_id)
 
         c = self._fixCalendar(name="Yølp", cal_id=self.testcal_id)
@@ -3519,19 +3495,13 @@ def testUtf8Event(self):
         if "zimbra" not in str(c.url):
             assert len(events) == 1
 
-        if (
-            not self.check_compatibility_flag("unique_calendar_ids")
-            and self.cleanup_regime == "post"
-        ):
+        if self.cleanup_regime == "post":
             self._teardownCalendar(cal_id=self.testcal_id)
 
     def testUnicodeEvent(self):
         self.skip_unless_support("save-load.event")
         self.skip_unless_support("create-calendar")
-        if not self.check_compatibility_flag("unique_calendar_ids") and self.cleanup_regime in (
-            "light",
-            "pre",
-        ):
+        if self.cleanup_regime in ("light", "pre"):
             self._teardownCalendar(cal_id=self.testcal_id)
         c = self._fixCalendar(name="Yølp", cal_id=self.testcal_id)
 
@@ -3565,18 +3535,15 @@ def testSetCalendarProperties(self):
 
         # Creating a new calendar with different ID but with existing name
         # TODO: why do we do this?
-        if not self.check_compatibility_flag("unique_calendar_ids") and self.cleanup_regime in (
-            "light",
-            "pre",
-        ):
+        # TODO: we're doing this all over the placee, it should be consolidated
+        # TODO: it should be in the test setup/teardown
+        if self.cleanup_regime in ("light", "pre"):
             self._teardownCalendar(cal_id=self.testcal_id2)
         cc = self._fixCalendar(name="Yep", cal_id=self.testcal_id2)
         try:
             cc.delete()
         except error.DeleteError:
-            if not self.is_supported("delete-calendar") or self.check_compatibility_flag(
-                "unique_calendar_ids"
-            ):
+            if not self.is_supported("delete-calendar"):
                 raise
 
         c.set_properties(