refactor: move response-related logic from protocol/ into response.py

- Moved all result dataclasses (PropfindResult, CalendarQueryResult,
  SyncCollectionResult, MultistatusResponse) and XML parse functions
  (_parse_multistatus, _parse_propfind_response, etc.) from
  protocol/types.py and protocol/xml_parsers.py into response.py,
  which is the natural home for response-parsing logic.

- Deleted protocol/types.py and protocol/xml_parsers.py entirely.
  protocol/__init__.py now re-exports the result types from response.py.

- Added parse_propfind(), parse_calendar_query(), parse_sync_collection()
  as instance methods on BaseDAVResponse so callers can simply do
  `response.parse_propfind()` instead of passing raw bytes, status code
  and huge_tree as arguments to a standalone function.

- Dropped MultiGetResult dataclass — it was an exact structural copy of
  CalendarQueryResult with no distinct semantics and was never imported
  in production code.

- Updated async_davclient.py and davclient.py to use the new instance
  methods (eliminating the raw-bytes boilerplate at each call site).

- Fixed unit tests that were mocking _async_get_vcal_address directly
  instead of the dual-mode get_vcal_address; and removed the TestDAVTypes
  class that tested now-deleted Sans-IO types (DAVRequest, DAVResponse).

prompt: All response-related logic in the protocol directory should be moved back to the response class.
followup-prompt: Make sure there is no duplicated code or logic. I feel more comfortable having things organized as methods under the Response class than having them as pure functions, consider if any of the functions moved over would fit as methods. Those new dataclasses, make sure they are either used consequently whenever it makes sense, or that they are dropped completely. Make me an overview of places where those new functions and classes are used, when not being called from the Response class.

AI Prompts:
claude-sonnet-4-6: All response-related logic in the protocol directory should be moved back to the response class.

Author: tobixen

caldav/async_davclient.py

@@ -71,23 +71,14 @@ def auth_flow(self, request):
 from caldav.lib import error
 from caldav.lib.python_utilities import to_wire
 from caldav.lib.url import URL
-from caldav.protocol.types import (
-    CalendarQueryResult,
-    PropfindResult,
-)
 from caldav.protocol.xml_builders import (
     _build_calendar_multiget_body,
     _build_calendar_query_body,
     _build_propfind_body,
     _build_sync_collection_body,
 )
-from caldav.protocol.xml_parsers import (
-    _parse_calendar_query_response,
-    _parse_propfind_response,
-    _parse_sync_collection_response,
-)
 from caldav.requests import HTTPBearerAuth
-from caldav.response import BaseDAVResponse
+from caldav.response import BaseDAVResponse, CalendarQueryResult, PropfindResult
 
 log = logging.getLogger("caldav")
 
@@ -562,14 +553,8 @@ async def propfind(
         final_headers = self._build_method_headers("PROPFIND", depth, headers)
         response = await self.request(url or str(self.url), "PROPFIND", body, final_headers)
 
-        # Parse response using protocol layer
         if response.status in (200, 207) and response._raw:
-            raw_bytes = (
-                response._raw if isinstance(response._raw, bytes) else response._raw.encode("utf-8")
-            )
-            response.results = _parse_propfind_response(
-                raw_bytes, response.status, response.huge_tree
-            )
+            response.results = response.parse_propfind()
 
         return response
 
@@ -779,14 +764,8 @@ async def calendar_query(
             url or str(self.url), "REPORT", body.decode("utf-8"), final_headers
         )
 
-        # Parse response using protocol layer
         if response.status in (200, 207) and response._raw:
-            raw_bytes = (
-                response._raw if isinstance(response._raw, bytes) else response._raw.encode("utf-8")
-            )
-            response.results = _parse_calendar_query_response(
-                raw_bytes, response.status, response.huge_tree
-            )
+            response.results = response.parse_calendar_query()
 
         return response
 
@@ -816,14 +795,8 @@ async def calendar_multiget(
             url or str(self.url), "REPORT", body.decode("utf-8"), final_headers
         )
 
-        # Parse response using protocol layer
         if response.status in (200, 207) and response._raw:
-            raw_bytes = (
-                response._raw if isinstance(response._raw, bytes) else response._raw.encode("utf-8")
-            )
-            response.results = _parse_calendar_query_response(
-                raw_bytes, response.status, response.huge_tree
-            )
+            response.results = response.parse_calendar_query()
 
         return response
 
@@ -855,14 +828,8 @@ async def sync_collection(
             url or str(self.url), "REPORT", body.decode("utf-8"), final_headers
         )
 
-        # Parse response using protocol layer
         if response.status in (200, 207) and response._raw:
-            raw_bytes = (
-                response._raw if isinstance(response._raw, bytes) else response._raw.encode("utf-8")
-            )
-            sync_result = _parse_sync_collection_response(
-                raw_bytes, response.status, response.huge_tree
-            )
+            sync_result = response.parse_sync_collection()
             response.results = sync_result.changed
             response.sync_token = sync_result.sync_token
 

caldav/davclient.py

@@ -717,16 +717,8 @@ def propfind(
         headers = {"Depth": str(depth)}
         response = self.request(url or str(self.url), "PROPFIND", body, headers)
 
-        # Parse response using protocol layer
         if response.status in (200, 207) and response._raw:
-            from caldav.protocol.xml_parsers import _parse_propfind_response
-
-            raw_bytes = (
-                response._raw if isinstance(response._raw, bytes) else response._raw.encode("utf-8")
-            )
-            response.results = _parse_propfind_response(
-                raw_bytes, response.status, response.huge_tree
-            )
+            response.results = response.parse_propfind()
         return response
 
     def proppatch(self, url: str, body: str, dummy: None = None) -> DAVResponse:

caldav/protocol/__init__.py

@@ -1,44 +1,20 @@
 """
-Sans-I/O CalDAV protocol implementation.
+CalDAV protocol layer — XML builders and (legacy) re-exports.
 
-This module provides protocol-level operations without any I/O.
-It builds requests and parses responses as pure data transformations.
-
-The protocol layer is organized into:
-- types: Core data structures (DAVRequest, DAVResponse, result types)
-- xml_builders: Internal functions to build XML request bodies
-- xml_parsers: Internal functions to parse XML response bodies
-
-Both DAVClient (sync) and AsyncDAVClient (async) use these shared
-functions for XML building and parsing, ensuring consistent behavior.
-
-Note: The xml_builders and xml_parsers functions are internal implementation
-details and should not be used directly. Use the client methods instead.
+The xml_builders submodule provides functions to build CalDAV request XML.
+Result dataclasses previously defined here have been moved to caldav.response.
 """
 
-from .types import (
+from caldav.response import (
     CalendarQueryResult,
-    DAVMethod,
-    DAVRequest,
-    DAVResponse,
-    MultiGetResult,
     MultistatusResponse,
-    PrincipalInfo,
     PropfindResult,
     SyncCollectionResult,
 )
 
 __all__ = [
-    # Enums
-    "DAVMethod",
-    # Request/Response
-    "DAVRequest",
-    "DAVResponse",
-    # Result types
     "CalendarQueryResult",
-    "MultiGetResult",
     "MultistatusResponse",
-    "PrincipalInfo",
     "PropfindResult",
     "SyncCollectionResult",
 ]