test: Fix lychee setup and links. Fix ox breakages.

Author: tobixen

.github/workflows/linkcheck.yml

@@ -1,18 +1,35 @@
 name: Link check
 
-on: [push, pull_request]
+on:
+  push:
+  pull_request:
+  workflow_dispatch:
+  schedule:
+   - cron: "03 22 * * *"
 
 jobs:
   linkcheck:
     runs-on: ubuntu-latest
+    permissions:
+      issues: write
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v5
     - name: Check links with Lychee
+      id: lychee
       uses: lycheeverse/lychee-action@v2
       with:
-        fail: true
+        fail: false
         args: >-
+          --root-dir "$(pwd)"
           --timeout 20
           --max-retries 3
-          '**/*.md'
-          '**/*.rst'
+          --cache
+          --max-cache-age 14d
+          .
+    - name: Create Issue From File
+      if: steps.lychee.outputs.exit_code != 0
+      uses: peter-evans/create-issue-from-file@v5
+      with:
+        title: Link Checker Report
+        content-filepath: ./lychee/out.md
+        labels: report, automated issue

.lycheeignore

@@ -4,6 +4,7 @@ https?://.*\.example\.com/.*
 
 # Localhost URLs for test servers (not accessible in CI)
 http://localhost:\d+/.*
+http://localhost/.*
 
 # CalDAV endpoints that require authentication (401/403 expected)
 https://caldav\.fastmail\.com/.*
@@ -16,5 +17,17 @@ https://webmail\.all-inkl\.com/.*
 https://www\.google\.com/calendar/dav/.*
 https://caldav-jp\.larksuite\.com/.*
 
-# Apple namespace URL (returns 404 but is a valid XML namespace reference)
+# Misc old namespace URLs, few of them works
 http://apple\.com/ns/ical/
+http://cal.me.com/_namespace/
+http://nextcloud.org/ns
+http://owncloud.org/ns
+
+
+# Other junk that was never meant to be followed
+# lychee converts unknown schemes to file:// URLs before matching ignore patterns
+file://.*/scheme:.*
+/17149682/.*
+http://x/
+https://ecloud\.global/remote\.php/.*
+https://tobixen@e\.email/remote\.php/dav

.pre-commit-config.yaml

@@ -24,6 +24,6 @@ repos:
     rev: lychee-v0.22.0
     hooks:
       - id: lychee
-        args: ["--no-progress", "--timeout", "10"]
-        types: [markdown, rst]
-        stages: [manual]  # Run with: pre-commit run lychee --hook-stage manual
+        args: ["--no-progress", "--timeout", "10", "--exclude-path", ".lycheeignore"]
+        stages: [pre-push]
+        exclude: ^tests/test_caldav_unit\.py$

CHANGELOG.md

@@ -198,7 +198,7 @@ Additionally, direct `DAVClient()` instantiation should migrate to `get_davclien
 
 ### Changed
 * Optimilizations on data conversions in the `CalendarObjectResource` properties (https://github.com/python-caldav/caldav/issues/613 )
-* Lazy imports (PEP 562) -- `import caldav` is now significantly faster.  Heavy dependencies (lxml, niquests, icalendar) are deferred until first use.  https://github.com/python-caldav/caldav/pull/621
+* Lazy imports (PEP 562) -- `import caldav` is now significantly faster.  Heavy dependencies (lxml, niquests, icalendar) are deferred until first use.  https://github.com/python-caldav/caldav/issues/621
 * Search refactored to use generator-based Sans-I/O pattern -- `_search_impl` yields `(SearchAction, data)` tuples consumed by sync or async wrappers
 * Configuration system expanded: `get_connection_params()` provides unified config discovery with clear priority (explicit params > test server config > env vars > config file)
 * `${VAR}` and `${VAR:-default}` environment variable expansion in config values

CONTRIBUTING.md

@@ -25,7 +25,7 @@ The `compatibility_hints.py` has been moved from the test directory to the codeb
 
 This is not set in stone.  If you feel strongly for using something else, use something else in the commit message and update this file in the same commit.
 
-"Imperative mood" is to be used in commit messages.
+"Imperative presens" or "imperative mood" is to be used in commit messages.
 
 The boundaries of breaking changes vs "non-breaking" changes [may be blurry](https://xkcd.com/1172/). In the CHANGELOG I've used the concept "potentially breaking changes" for things that most likely won't break anything for anyone.  Potentially breaking changes should be marked with `!` in the commit header.  Breaking changes should be marked both with `!` and `BREAKING CHANGE:`
 
@@ -62,11 +62,9 @@ Consider this procedures to be a more of a guideline than a rigid procedure.  Us
 
 * Write up your changes
 
-* Run `pytest` for a quick run of the tests.  They should still pass.
+* Run `pytest`.  The tests should still pass.  (Beware: tests may take very long time to run and may consume a lot of memory and disk space if the tests have the permissions to start docker containers).
 
-* Run `tox -e style` to verify a consistent code style (this may modify your code).
-
-* Consider to write some lines in the documentation and/or examples covering your change
+* Consider to write some lines in the documentation, changelog and/or examples covering your change
 
 * Add an entry in the `CHANGELOG.md` file.
 

caldav/compatibility_hints.py

@@ -855,42 +855,33 @@ def dotted_feature_set_list(self, compact=False):
     ]
 }
 
-xandikos_v0_3 = {
+xandikos = {
+    ## We've sometimes been observing internal server errors on freebusy-requests.
+    ## Should do more research on it next time it shows up.
+
+    ## Component type filtering is required - searches must specify event=True or todo=True
+    "search.comp-type.optional": "unsupported",
+
+    ## Principal property search returns 403 (not implemented)
+    "principal-search": "ungraceful",
+
+    ## Server-side recurrence expansion is buggy for tasks and event exceptions
+    "search.recurrences.expanded.todo": "unsupported",
+    "search.recurrences.expanded.exception": "unsupported",
+
     ## this only applies for very simple installations
     "auto-connect.url": {"domain": "localhost", "scheme": "http", "basepath": "/"},
-    'search.comp-type.optional': {'support': 'unsupported'},
-    ## This suddenly disappeared.  Should probably look more into the checks ...
-    #"search.recurrences.includes-implicit.todo.pending": {"support": "unsupported"},
-    'search.recurrences.expanded.todo': {'support': 'unsupported'},
-    'search.recurrences.expanded.exception': {'support': 'unsupported'},
-    'principal-search': {'support': 'ungraceful'},
-    'freebusy-query.rfc4791': {'support': 'ungraceful', 'behaviour': '500 internal server error'},
+
     "old_flags":  [
     ## https://github.com/jelmer/xandikos/issues/8
     'date_todo_search_ignores_duration',
     'vtodo_datesearch_nostart_future_tasks_delivered',
 
     ## scheduling is not supported
     "no_scheduling",
-
-    ## The test with an rrule and an overridden event passes as
-    ## long as it's with timestamps.  With dates, xandikos gets
-    ## into troubles.  I've chosen to edit the test to use timestamp
-    ## rather than date, just to have the test exercised ... but we
-    ## should report this upstream
-    #'broken_expand_on_exceptions',
-
     ]
 }
 
-xandikos_main = xandikos_v0_3.copy()
-## woot ... a regression?
-## xandikos did support freebusy-query.rfc4791 for a while, now it trips on a traceback
-## TODO: do research into this and report
-#xandikos_main.pop('freebusy-query.rfc4791')
-
-xandikos = xandikos_main
-
 ## This seems to work as of version 3.5.4 of Radicale.
 ## There is much development going on at Radicale as of summar 2025,
 ## so I'm expecting this list to shrink a lot soon.
@@ -928,6 +919,7 @@ def dotted_feature_set_list(self, compact=False):
     'search.comp-type.optional': {'support': 'ungraceful'},
     'search.recurrences.expanded.todo': {'support': 'unsupported'},
     'search.recurrences.expanded.exception': {'support': 'unsupported'}, ## TODO: verify
+    "search.recurrences.includes-implicit.infinite-scope": False,
     'delete-calendar': {
         'support': 'fragile',
         'behaviour': 'Deleting a recently created calendar fails'},
@@ -979,6 +971,7 @@ def dotted_feature_set_list(self, compact=False):
     'sync-token': {'support': 'fragile'},
     'search.is-not-defined': {'support': 'unsupported'},
     'search.text': {'support': 'unsupported'},
+    "search.recurrences.includes-implicit.infinite-scope": False,
     # sometimes throws a 500
     'search.text.category': {'support': 'ungraceful'},
     'search.recurrences.expanded.todo': { "support": "unsupported" },
@@ -1011,60 +1004,35 @@ def dotted_feature_set_list(self, compact=False):
 }
 
 bedework = {
-    'search.comp-type': {'support': 'broken', 'behaviour': 'Server returns everything when searching for events and nothing when searching for todos'},
-    'search.comp-type.optional': {'support': 'ungraceful'},
-    #'search.time-range.event': {'support': 'unsupported'}, ## TODO: flapping??
-    #"search.combined-is-logical-and": { "support": "unsupported" },
-    ## TODO: play with this and see if it's needed
+    ## If tests are yielding unexpected results, try to increase this:
     'search-cache': {'behaviour': 'delay', 'delay': 1.5},
-    ## TODO: play with this and see if it's needed
-    'old_flags': [
-    'propfind_allprop_failure',
-    'duplicates_not_allowed',
-    ],
-    # Ephemeral Docker container: wipe objects (delete-calendar not supported)
+
     'test-calendar': {'cleanup-regime': 'wipe-calendar'},
     'auto-connect.url': {'basepath': '/ucaldav/'},
     'save-load.journal': {'support': 'ungraceful'},
     'save-load.todo.recurrences.thisandfuture': {'support': 'ungraceful'},
     'save-load.event.recurrences.exception': False,
-    ## search.time-range.alarm: not checked by the server tester
     'search.time-range.alarm': {'support': 'unsupported'},
-    ## Huh?  Non-deterministic behaviour of the checking script?
-    #"save.duplicate-uid.cross-calendar": {
-    #    "support": "unsupported",
-    #    "behaviour": "silently-ignored"
-    #},
-    "freebusy-query.rfc4791": {
-        "support": "full"
-    },
-    "search.time-range.todo": {
-        "support": "unsupported"
-    },
+    "freebusy-query.rfc4791": True,
+    "search.time-range.todo": False,
     "search.text": False, ## sometimes ungraceful
-    "search.is-not-defined": {
-        "support": "fragile"
-    },
-    "search.recurrences.includes-implicit": {
-        "support": "unsupported",
-        "behaviour": "cannot reliably test due to broken comp-type filtering"
-    },
-    "sync-token": {
-        "support": "fragile"
-    },
-    ## Check results are non-deterministic!?
-    "search.recurrences.expanded.exception": {
-        "support": "unsupported"
-    },
-    "search.recurrences.expanded.event": {
-        "support": "unsupported"
-    },
-    "search.recurrences.expanded.todo": {
-        "support": "unsupported"
-    },
-    "principal-search": {
-        "support": "ungraceful",
-    },
+    "search.recurrences.includes-implicit": False,
+    "sync-token": { "support": "fragile" },
+    "search.recurrences.expanded.exception": False,
+    "search.recurrences.expanded.event": False,
+    "search.recurrences.expanded.todo": False,
+    'search.comp-type': {'support': 'broken', 'behaviour': 'Server returns everything when searching for events and nothing when searching for todos'},
+    'search.comp-type.optional': {'support': 'ungraceful'},
+    'search.is-not-defined.dtend': False,
+    "principal-search": {  "support": "ungraceful" },
+    "search.unlimited-time-range": {"support": "broken"},
+
+    ## TODO: play with this and see if it's needed
+    'old_flags': [
+    'propfind_allprop_failure',
+    'duplicates_not_allowed',
+    ],
+
 }
 
 synology = {
@@ -1086,6 +1054,7 @@ def dotted_feature_set_list(self, compact=False):
     'search.recurrences.expanded.todo': {'support': 'unsupported'},
     'search.recurrences.expanded.exception': {'support': 'unsupported'},
     'search.recurrences.includes-implicit.todo': {'support': 'unsupported'},
+    "search.recurrences.includes-implicit.infinite-scope": False,
     'save-load.journal.mixed-calendar': {'support': 'unsupported'},
     'principal-search': {'support': 'ungraceful'},
     'principal-search.by-name.self': {'support': 'unsupported'},
@@ -1109,6 +1078,7 @@ def dotted_feature_set_list(self, compact=False):
 cyrus = {
     "search.comp-type.optional": {"support": "ungraceful"},
     "search.recurrences.expanded.exception": {"support": "unsupported"},
+    "search.recurrences.includes-implicit.infinite-scope": False,
     "search.time-range.alarm": {"support": "ungraceful"},
     'principal-search': {'support': 'ungraceful'},
     # Cyrus enforces unique UIDs across all calendars for a user
@@ -1322,6 +1292,7 @@ def dotted_feature_set_list(self, compact=False):
     "search.recurrences.expanded.todo": {"support": "unsupported"},
     "search.recurrences.expanded.exception": {"support": "unsupported"},
     "search.recurrences.includes-implicit.todo": {"support": "unsupported"},
+    "search.recurrences.includes-implicit.infinite-scope": False,
     "principal-search.by-name.self": {"support": "unsupported"},
     "principal-search": {"support": "ungraceful"},
     "save-load.journal.mixed-calendar": {"support": "unsupported"},

tests/test_caldav.py

@@ -1272,10 +1272,13 @@ def testCreateEventFromiCal(self, klass):
             ## Calendar.new() is supported from icalendar 7, which is yet to be released as of 2025-09
             pytest.skip("Newer icalendar version required")
 
+        ## Use a near-future date so servers with a "sliding window" (e.g. OX) can find the event
+        start = datetime.now() + timedelta(days=30)
+        end = start + timedelta(hours=1)
         icalevent = icalendar.Event.new(
             uid="ctuid1",
-            start=datetime(2015, 10, 10, 8, 7, 6),
-            end=datetime(2015, 10, 10, 9, 7, 6),
+            start=start,
+            end=end,
             summary="This is a test event",
         )
         icalcal.add_component(icalevent)