chore: reduce ruff ignore list; fix 302 redirect in sync _put()

Code quality pass per #634:
* Remove unused imports (copy, lxml.etree, caldav.compatibility_hints,
  CalendarSet, cdav/dav, Optional, timezone, Event/Todo TYPE_CHECKING stubs,
  bare `import niquests` availability check)
* Replace bare `except:` with specific types (KeyError, AttributeError,
  Exception) across lib/error, lib/debug, lib/vcal, elements/cdav,
  calendarobjectresource, collection, compatibility_hints, davobject
* Remove unused local variables (old_id, status, i, path, rv, feat_type,
  sup, feature_info, rc) across library modules
* Use `# noqa: F401` for vobject availability checks in calendarobjectresource

Sync _put() now updates self.url from the Location header on a 302 redirect,
matching the existing async _async_put() behaviour.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: tobixen

CHANGELOG.md

@@ -28,6 +28,11 @@ This project should adhere to [Semantic Versioning](https://semver.org/spec/v2.0
   * async path returned an unawaited coroutine instead of the actual result.
 * `accept_invite()` (and `decline_invite()`, `tentatively_accept_invite()`) now fall back to the client username as the attendee email address when the server does not expose the `calendar-user-address-set` property (RFC6638 §2.4.1).  A `NotFoundError` with a descriptive message is raised when the username is also not an email address.  Fixes https://github.com/python-caldav/caldav/issues/399
 
+### Housekeeping
+
+* Code quality: reduced ruff ignore list (https://github.com/python-caldav/caldav/issues/634) — removed unused imports (`copy`, `lxml.etree`, `CalendarSet`, `cdav/dav` re-exports, `Optional`, `timezone`, `Event`/`Todo` type stubs), replaced bare `except:` clauses with specific exception types (`KeyError`, `AttributeError`, `Exception` where broad catching is intentional), and removed unused local variables.
+* Sync `_put()` now updates `self.url` from the `Location` header on a 302 redirect, mirroring the existing async behaviour.
+
 ### Test framework, compatibility hints, documentation, examples
 
 * RFC 6638 scheduling feature-detection infrastructure: new `scheduling`, `scheduling.mailbox`, and `scheduling.calendar-user-address-set` compatibility hints; legacy `no_scheduling` flags migrated.  Default scheduling hints set for all the servers tested.

caldav/async_davclient.py

@@ -15,7 +15,7 @@
 from urllib.parse import unquote
 
 if TYPE_CHECKING:
-    from caldav.calendarobjectresource import CalendarObjectResource, Event, Todo
+    from caldav.calendarobjectresource import CalendarObjectResource
     from caldav.collection import Calendar, Principal
 
 # Try httpx first (preferred), fall back to niquests
@@ -50,7 +50,6 @@ def auth_flow(self, request):
 
 if not _USE_HTTPX:
     try:
-        import niquests
         from niquests import AsyncSession
         from niquests.structures import CaseInsensitiveDict
 

caldav/calendarobjectresource.py

@@ -139,7 +139,7 @@ def __init__(
         if data is not None:
             self.data = data
             if id and self._get_component_type_cheap():
-                old_id = self.icalendar_component.pop("UID", None)
+                self.icalendar_component.pop("UID", None)
                 self.icalendar_component.add("UID", id)
                 # Clear raw data and update state to use the modified icalendar instance
                 self._data = None
@@ -985,11 +985,11 @@ def _put(self, retry_on_failure=True):
         ## SECURITY TODO: we should probably have a check here to verify that no such object exists already
         r = self.client.put(self.url, self.data, {"Content-Type": 'text/calendar; charset="utf-8"'})
         if r.status == 302:
-            path = [x[1] for x in r.headers if x[0] == "location"][0]
+            self.url = URL.objectify([x[1] for x in r.headers if x[0] == "location"][0])
         elif r.status not in (204, 201):
             if retry_on_failure:
                 try:
-                    import vobject
+                    import vobject  # noqa: F401
                 except ImportError:
                     retry_on_failure = False
             if retry_on_failure:
@@ -1013,7 +1013,7 @@ async def _async_put(self, retry_on_failure=True):
         elif r.status not in (204, 201):
             if retry_on_failure:
                 try:
-                    import vobject
+                    import vobject  # noqa: F401
                 except ImportError:
                     retry_on_failure = False
             if retry_on_failure:
@@ -1468,7 +1468,7 @@ def _set_icalendar_instance(self, inst):
             try:  ## DEPRECATION TODO: remove this try/except the future
                 ## icalendar 7.x behaviour (not released yet as of 2025-09
                 cal = icalendar.Calendar.new()
-            except:
+            except AttributeError:
                 cal = icalendar.Calendar()
                 cal.add("prodid", "-//python-caldav//caldav//en_DK")
                 cal.add("version", "2.0")
@@ -2087,7 +2087,7 @@ def _complete_ical(self, i=None, completion_timestamp=None) -> None:
         if i is None:
             i = self.icalendar_component
         assert self.is_pending(i)
-        status = i.pop("STATUS", None)
+        i.pop("STATUS", None)
         i.add("STATUS", "COMPLETED")
         i.add("COMPLETED", completion_timestamp)
 
@@ -2166,7 +2166,6 @@ def set_due(self, due, move_dtstart=False, check_dependent=False):
         WARNING: the check_dependent-logic may be rewritten to support
         RFC9253 in 3.x
         """
-        i = self.icalendar_component
         if hasattr(due, "tzinfo") and not due.tzinfo:
             due = due.astimezone(timezone.utc)
         if check_dependent:

caldav/collection.py

@@ -604,7 +604,7 @@ def _create(
 
         mkcol = (dav.Mkcol() if method == "mkcol" else cdav.Mkcalendar()) + set
 
-        r = self._query(root=mkcol, query_method=method, url=path, expected_return_value=201)
+        self._query(root=mkcol, query_method=method, url=path, expected_return_value=201)
 
         # COMPATIBILITY ISSUE
         # name should already be set, but we've seen caldav servers failing
@@ -619,7 +619,7 @@ def _create(
                 try:
                     current_display_name = self.get_display_name()
                     error.assert_(current_display_name == name)
-                except:
+                except Exception:
                     log.warning(
                         "calendar server does not support display name on calendar?  Ignoring",
                         exc_info=True,
@@ -680,7 +680,7 @@ async def _async_create(
                 try:
                     current_display_name = await self._async_get_property(dav.DisplayName())
                     error.assert_(current_display_name == name)
-                except:
+                except Exception:
                     log.warning(
                         "calendar server does not support display name on calendar?  Ignoring",
                         exc_info=True,
@@ -973,7 +973,6 @@ def _multiget(self, event_urls: Iterable[URL], raise_notfound: bool = False) ->
         if self.url is None:
             raise ValueError("Unexpected value None for self.url")
 
-        rv = []
         prop = dav.Prop() + cdav.CalendarData()
         root = cdav.CalendarMultiGet() + prop + [dav.Href(value=u.path) for u in event_urls]
         # RFC 4791 section 7.9: "the 'Depth' header MUST be ignored by the
@@ -1713,7 +1712,7 @@ def get_objects_by_sync_token(
                 ## TODO: look more into this, I think sync_token should be directly available through response object
                 try:
                     sync_token = response.sync_token
-                except:
+                except AttributeError:
                     sync_token = response.tree.findall(".//" + dav.SyncToken.tag)[0].text
 
                 ## this is not quite right - the etag we've fetched can already be outdated
@@ -1873,7 +1872,7 @@ def __init__(
                 # we ignore the type here as this is defined in sub-classes only; require more changes to
                 # properly fix in a future revision
                 self.url = self.client.url.join(URL(self.get_property(self.findprop())))  # type: ignore
-            except:
+            except Exception:
                 logging.error("something bad happened", exc_info=True)
                 error.assert_(self.client.check_scheduling_support())
                 self.url = None
@@ -1891,7 +1890,7 @@ def get_items(self):
         if not self._items:
             try:
                 self._items = self.objects(load_objects=True)
-            except:
+            except Exception:
                 logging.debug(
                     "caldav server does not seem to support a sync-token REPORT query on a scheduling mailbox"
                 )
@@ -1904,7 +1903,7 @@ def get_items(self):
         else:
             try:
                 self._items.sync()
-            except:
+            except Exception:
                 self._items = [
                     CalendarObjectResource(url=x[0], client=self.client) for x in self.children()
                 ]

caldav/compatibility_hints.py

@@ -375,9 +375,6 @@ def set_feature(self, feature, value=True):
         else:
             raise AssertionError
         self.copyFeatureSet(fc, collapse=False)
-        feat_def = self.find_feature(feature)
-        feat_type = feat_def.get('type', 'server-feature')
-        sup = fc[feature].get('support', feat_def.get('default', 'full'))
 
 
     ## TODO: Why is this camelCase while every other method is with under_score?  rename ...
@@ -396,7 +393,6 @@ def copyFeatureSet(self, feature_set, collapse=True):
                     UserWarning,
                     stacklevel=3,
                 )
-                feature_info = {}
             value = feature_set[feature]
             if feature not in self._server_features:
                 self._server_features[feature] = {}
@@ -570,7 +566,7 @@ def _derive_from_subfeatures(self, feature, feature_info, return_type, accept_fr
                 subfeature_info = self.find_feature(subfeature_key)
                 if 'default' in subfeature_info:
                     continue
-            except:
+            except Exception:
                 pass
 
             total_relevant += 1

caldav/davclient.py

@@ -8,7 +8,6 @@
 For async code, use: from caldav import aio
 """
 
-import copy
 import logging
 import sys
 import time
@@ -38,19 +37,15 @@
 
 from collections.abc import Mapping
 
-from lxml import etree
-
-import caldav.compatibility_hints
 from caldav import __version__
 from caldav.base_client import BaseDAVClient
 from caldav.base_client import get_calendars as _base_get_calendars
 from caldav.base_client import get_davclient as _base_get_davclient
-from caldav.collection import Calendar, CalendarSet, Principal
+from caldav.collection import Calendar, Principal
 from caldav.compatibility_hints import FeatureSet
 
 # Re-export CONNKEYS for backward compatibility
 from caldav.config import CONNKEYS  # noqa: F401
-from caldav.elements import cdav, dav
 from caldav.lib import error
 from caldav.lib.python_utilities import to_wire
 from caldav.lib.url import URL
@@ -65,7 +60,7 @@
     from typing import Self
 
 if TYPE_CHECKING:
-    from caldav.calendarobjectresource import CalendarObjectResource, Event, Todo
+    from caldav.calendarobjectresource import CalendarObjectResource
 
 
 """

caldav/davobject.py

@@ -389,7 +389,6 @@ def get_properties(
         if self.is_async_client:
             return self._async_get_properties(props, depth, parse_response_xml, parse_props)
 
-        rc = None
         response = self._query_properties(props, depth)
         if not parse_response_xml:
             return response
@@ -427,7 +426,6 @@ async def _async_get_properties(
         parse_props: bool = True,
     ):
         """Async implementation of get_properties."""
-        rc = None
         response = await self._async_query_properties(props, depth)
         if not parse_response_xml:
             return response
@@ -577,7 +575,7 @@ def name(self) -> str | None:
     def __str__(self) -> str:
         try:
             return str(self.get_property(dav.DisplayName(), use_cached=True)) or self.url
-        except:
+        except Exception:
             return str(self.url)
 
     def __repr__(self) -> str:

caldav/elements/cdav.py

@@ -20,7 +20,7 @@ def _to_utc_date_string(ts):
             ## in python 3.6 and higher, ts.astimezone() will assume a
             ## naive timestamp is localtime (and so do we)
             ts = ts.astimezone(utc_tz)
-        except:
+        except (OverflowError, OSError):
             ## native time stamp and the current python version is
             ## not able to treat it as localtime.
             import tzlocal

caldav/jmap/convert/_utils.py

@@ -4,7 +4,7 @@
 
 from __future__ import annotations
 
-from datetime import date, datetime, timedelta, timezone
+from datetime import date, datetime, timedelta
 
 
 def _timedelta_to_duration(td: timedelta) -> str:

caldav/lib/debug.py

@@ -8,7 +8,7 @@ def xmlstring(root):
         root = root.xmlelement()
     try:
         return etree.tostring(root, pretty_print=True).decode("utf-8")
-    except:
+    except Exception:
         return root