alarm creation and search works

Author: tobixen

caldav/davclient.py

@@ -310,7 +310,9 @@ def _expand_simple_prop(
         values = []
         if proptag in props_found:
             prop_xml = props_found[proptag]
-            error.assert_(not prop_xml.items())
+            if prop_xml.items():
+                from caldav.lib.debug import xmlstring
+                log.error(f"If you see this, please add a report at https://github.com/python-caldav/caldav/issues/209 - in _expand_simple_prop, dealing with {proptag}, extra items found: {xmlstring(prop_xml)}.")
             if not xpath and len(prop_xml) == 0:
                 if prop_xml.text:
                     values.append(prop_xml.text)

tests/compatibility_issues.py

@@ -44,6 +44,9 @@
         """date searches covering recurrances may yield no results, """
         """and events/todos may not be expanded with recurrances""",
 
+    'no_alarmsearch':
+        """Searching for alarms may yield too few or too many or even a 500 internal server error""",
+
     'no_recurring_todo':
         """Recurring events are supported, but not recurring todos""",
 
@@ -271,6 +274,9 @@
     ## rather than date, just to have the test exercised ... but we
     ## should report this upstream
     #'broken_expand_on_exceptions',
+    
+    ## No alarm search (500 internal server error)
+    "no_alarmsearch",
 ]
 
 ## This can soon be removed (relevant for running tests under python 3.7 and python 3.8)
@@ -286,11 +292,14 @@
 except Exception:
     pass
 
+## TODO - there has been quite some development in radicale recently, so this list
+## should probably be gone through
 radicale = [
     ## calendar listings and calendar creation works a bit
     ## "weird" on radicale
     "broken_expand",
     "no_default_calendar",
+    "no_alarmsearch", ## This is fixed and will be released soon
 
     ## freebusy is not supported yet, but on the long-term road map
     #"no_freebusy_rfc4791",

tests/test_caldav.py

@@ -987,14 +987,19 @@ def testAlarm(self):
         ## Ref https://github.com/python-caldav/caldav/issues/132
         c = self._fixCalendar()
         ev = c.save_event(
-            dtstart=datetime(2015, 10, 10, 8, 7, 6),
+            dtstart=datetime(2015, 10, 10, 8, 0, 0),
             summary="This is a test event",
-            dtend=datetime(2016, 10, 10, 9, 8, 7),
+            dtend=datetime(2016, 10, 10, 9, 0, 0),
             alarm_trigger=timedelta(minutes=-15),
             alarm_action="AUDIO",
         )
 
-        ## Search for the alarm (procrastinated - see https://github.com/python-caldav/caldav/issues/132)
+        self.skip_on_compatibility_flag("no_alarmsearch")
+
+        ## So we have an alarm that goes off 07:45 for an event starting 08:00
+        
+        ## Search for alarms after 8 should find nothing
+        ## (search for an alarm 07:55 - 08:05 should most likely find nothing).
         assert (
             len(
                 c.search(
@@ -1005,12 +1010,14 @@ def testAlarm(self):
             )
             == 0
         )
+        
+        ## Search for alarms from 07:40 to 07:55 should definitively find the alarm.
         assert (
             len(
                 c.search(
                     event=True,
-                    alarm_start=datetime(2015, 10, 10, 7, 44),
-                    alarm_end=datetime(2015, 10, 10, 8, 7),
+                    alarm_start=datetime(2015, 10, 10, 7, 40),
+                    alarm_end=datetime(2015, 10, 10, 7, 55),
                 )
             )
             == 1