A bug in loading davobject

[zealseeker]

caldav/caldav/calendarobjectresource.py

Lines 625 to 633 in a6c39da

	try:
	r = self.client.request(str(self.url))
	if r.status and r.status == 404:
	raise error.NotFoundError(errmsg(r))
	except error.NotFoundError:
	raise
	except:
	self.load_by_multiget()
	self.data = vcal.fix(r.raw)

When exception is catched during r = self.client.request(str(self.url)), r is not assigned and self.data = vcal.fix(r.raw) will raise an excpetion.

Maybe we should move self.data = vcal.fix(r.raw) to the try block or simply return self.load_by_multiget() as originally in #475

[tobixen]

I believe return self.load_by_multiget() is the correct thing here. Let me check up a bit.

[tobixen]

I've investigated and found:

• the vcal.fix is redundant, it's already done in the data-setter, so this logic should go away.
• It's not meant that the process should continue after the load_by_multiget - so it should be a return here.

Do you want to do a pull request, or should I just fix it?

[zealseeker]

OK. I'll create a pull request.