Revert #472 and re-address #471#473
Merged
Merged
Conversation
added 2 commits
April 24, 2025 20:44
Member
|
I was thinking a bit, but considered that in worst case it would propably only cause silly warnings about path handling problems on other servers. Anyway, good to have a better fix in place. |
Member
|
I'm not super happy about this one, with hard coded "magic" in it - but from a risk-assessment view it's safer than the previous edition, so I'll let it pass. :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #471 and #472
After having a deeper look at it, it seems that unquoting all properties could make other servers break.
I propose that we only apply a fix when the situation requires it only.
This will reduce error logging and hopefully won't break other servers.
This is the request and reply this PR addresses:
URL:
https://confluence.domain.com/plugins/servlet/team-calendars/caldav/principals/users/user@domain.com/Method: PROPFIND
RESPONSE: