Skip to content

Revert #472 and re-address #471 #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tobixen merged 2 commits into from
Apr 25, 2025
Merged

Revert #472 and re-address #471 #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48ddfc6
Revert #472 and re-address #471
Apr 25, 2025
ac92604
Applied tox -e style
Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions caldav/davclient.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,10 @@ def _parse_response(self, response) -> Tuple[str, List[_Element], Optional[Any]]
self.validate_status(status)
elif elem.tag == dav.Href.tag:
assert not href
# Fix for https://github.com/python-caldav/caldav/issues/471
# Confluence server quotes the user email twice. We unquote it manually.
if "%2540" in elem.text:
elem.text = elem.text.replace("%2540", "%40")
href = unquote(elem.text)
elif elem.tag == dav.PropStat.tag:
propstats.append(elem)
Expand Down
1 change: 0 additions & 1 deletion caldav/objects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,6 @@ def get_properties(
exchange_path = path[:-1]
else:
exchange_path = path + "/"
properties = {unquote(k): v for k, v in properties.items()}

if path in properties:
rc = properties[path]
Expand Down