Conversation
tobixen
changed the title
tobixen
force-pushed
the
issue638
branch
4 times, most recently
from
c68a8e0 to
2dd96da
Compare
Registers the CLASS property variant of the is-not-defined search feature, matching the existing .category and .dtend sub-features. Required by caldav-server-tester's CheckIsNotDefined check. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The debug_dump_communication / PYTHON_CALDAV_COMMDUMP feature was lost during the v3.0 refactor. Extract it into a shared _dump_communication() helper in caldav.lib.error so the logic is not duplicated between the sync (_sync_request) and async (_async_request) code paths. Fixes #638 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When search() is called with a full calendar-query XML and the server does not support search.comp-type.optional, the code raised NotImplementedError. Fall back to a single REPORT with the XML as-is (comp_class auto-detected from response data) for both the sync and async code paths. Fixes #637 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Merge `get_or_create_test_calendar` and `aget_or_create_test_calendar` into a shared async `_get_or_create_impl`, reducing ~130 lines of near-identical duplicated logic - Merge `_filter_calendars_by_component_set` + `_afilter_calendars_by_component_set` and `_find_test_calendar` + `_afind_test_calendar` into single async implementations using `_maybe_await` - Drop dead `get_properties_fn` parameter (was never passed by any caller) - Remove stale TODO comments from `_fixCalendar` in test_caldav.py - Trim docs/design/TODO.md: remove resolved and non-actionable items, condense Nextcloud UID-reuse bug entry Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm lumping various minor work into one pull request - just because I'm lazy. It's probably still better than to just toss the commits directly into the main branch ...
A NotImplementedError was replaced with proper code for #637 and a the debug communication log has been restored, both for async and sync, without any code duplication, and with test code this time.
The "fix" for #637 is a bit optimistic. At the other hand, this seems like a weird and deprecated corner case.
raise NotImplementedError(("full xml given, and it has to be patched to include comp_type")#637