Skip to content

Commit 4d6017f

Browse files
Partially apply ruff/flake8-simplify rule SIM115
SIM115 Use a context manager for opening files
1 parent 1838448 commit 4d6017f

3 files changed

Lines changed: 8 additions & 12 deletions

File tree

src/cffi/recompiler.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -287,9 +287,8 @@ def write_source_to_f(self, f, preamble):
287287
self.write_c_source_to_f(f, preamble)
288288

289289
def _rel_readlines(self, filename):
290-
g = open(os.path.join(os.path.dirname(__file__), filename), 'r')
291-
lines = g.readlines()
292-
g.close()
290+
with open(os.path.join(os.path.dirname(__file__), filename), 'r') as g:
291+
lines = g.readlines()
293292
return lines
294293

295294
def write_c_source_to_f(self, f, preamble):

testing/cffi0/test_verify.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,8 @@ def setup_module():
3838
def _write_source_and_check(self, file=None):
3939
base_write_source(self, file)
4040
if file is None:
41-
f = open(self.sourcefilename)
42-
data = f.read()
43-
f.close()
41+
with open(self.sourcefilename) as f:
42+
data = f.read()
4443
data = _r_comment.sub(' ', data)
4544
data = _r_string.sub('"skipped"', data)
4645
assert '$' not in data
@@ -1440,9 +1439,8 @@ def test_relative_to():
14401439
tmpdir = tempfile.mkdtemp(dir=str(udir))
14411440
ffi = FFI()
14421441
ffi.cdef("int foo(int);")
1443-
f = open(os.path.join(tmpdir, 'foo.h'), 'w')
1444-
f.write("int foo(int a) { return a + 42; }\n")
1445-
f.close()
1442+
with open(os.path.join(tmpdir, 'foo.h'), 'w') as f:
1443+
f.write("int foo(int a) { return a + 42; }\n")
14461444
lib = ffi.verify('#include "foo.h"',
14471445
include_dirs=['.'],
14481446
relative_to=os.path.join(tmpdir, 'x'))

testing/cffi1/test_verify1.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1410,9 +1410,8 @@ def test_relative_to():
14101410
tmpdir = tempfile.mkdtemp(dir=str(udir))
14111411
ffi = FFI()
14121412
ffi.cdef("int foo(int);")
1413-
f = open(os.path.join(tmpdir, 'foo.h'), 'w')
1414-
f.write("int foo(int a) { return a + 42; }\n")
1415-
f.close()
1413+
with open(os.path.join(tmpdir, 'foo.h'), 'w') as f:
1414+
f.write("int foo(int a) { return a + 42; }\n")
14161415
lib = ffi.verify('#include "foo.h"',
14171416
include_dirs=['.'],
14181417
relative_to=os.path.join(tmpdir, 'x'))

0 commit comments

Comments
 (0)