Open
Conversation
This setting worked well for some cases when cmd2 was using readline. However, due to subtle differences in how prompt-toolkit and readline work, setting this True provided a bad user experience with prompt-toolkit.
Also: - Clarified a parameter description to document how to accept fish-shell style auto-suggestions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1652 +/- ##
==========================================
- Coverage 99.49% 99.49% -0.01%
==========================================
Files 21 21
Lines 4747 4741 -6
==========================================
- Hits 4723 4717 -6
Misses 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
always_show_hintsettable.This setting worked well for some use cases when
cmd2was usingreadline. However, due to subtle differences in howprompt-toolkitandreadlinework, setting thisTrueprovided a bad user experience now thatcmd2is based onprompt-toolkit.Also:
auto_suggestparameter to document how to accept a suggestion