Skip to content

Remove always_show_hint settable#1652

Open
tleonhardt wants to merge 2 commits intomainfrom
ux-improvements
Open

Remove always_show_hint settable#1652
tleonhardt wants to merge 2 commits intomainfrom
ux-improvements

Conversation

@tleonhardt
Copy link
Copy Markdown
Member

Remove always_show_hint settable.

This setting worked well for some use cases when cmd2 was using readline. However, due to subtle differences in how prompt-toolkit and readline work, setting this True provided a bad user experience now that cmd2 is based on prompt-toolkit.

Also:

  • Added more explicit documentation for the auto_suggest parameter to document how to accept a suggestion

This setting worked well for some cases when cmd2 was using readline. However, due to subtle differences in how prompt-toolkit and readline work, setting this True provided a bad user experience with prompt-toolkit.
Also:
- Clarified a parameter description to document how to accept fish-shell style auto-suggestions
@tleonhardt tleonhardt requested a review from kmvanbrunt as a code owner April 24, 2026 23:06
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.49%. Comparing base (12a7d5e) to head (508898a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1652      +/-   ##
==========================================
- Coverage   99.49%   99.49%   -0.01%     
==========================================
  Files          21       21              
  Lines        4747     4741       -6     
==========================================
- Hits         4723     4717       -6     
  Misses         24       24              
Flag Coverage Δ
unittests 99.49% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant