Poetry to UV migration#3345
Merged
Merged
Conversation
jb3
added
a: dependencies
jb3
force-pushed
the
jb3/poetry-to-uv
branch
3 times, most recently
from
84770b9 to
96ba3be
Compare
ChrisLovering
approved these changes
Jul 15, 2025
MarkKoz
reviewed
Jul 15, 2025
| # Install project dependencies with build tools available | ||
| WORKDIR /build | ||
| RUN pip install --no-cache-dir --upgrade pip setuptools wheel virtualenv \ | ||
| && python -m virtualenv .venv |
Contributor
There was a problem hiding this comment.
Why not use stdlib venv? Does uv rely on virtualenv?
Comment on lines
+14
to
+17
| RUN --mount=type=cache,target=/root/.cache/uv \ | ||
| --mount=type=bind,source=uv.lock,target=uv.lock \ | ||
| --mount=type=bind,source=pyproject.toml,target=pyproject.toml \ | ||
| uv sync --frozen --no-dev |
Contributor
There was a problem hiding this comment.
We're doing bind mounts to avoid copying the files into the image, which would affect the build cache?
Co-authored-by: Johannes Christ <jc@jchri.st>
MarkKoz
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once more projects have migrated we will need to update Contributing guidance on site to reflect this.