-
-
Notifications
You must be signed in to change notification settings - Fork 747
Poetry to UV migration #3345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Poetry to UV migration #3345
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b1bf996
Migrate pyproject.toml to uv dependencies
jb3 08fdccd
Update pre-commit hooks to use uv
jb3 ba7fc3b
Update lint task to use uv
jb3 0496634
Update Dockerfile to use uv
jb3 ba0df62
Update README.md to reflect uv usage
jb3 20ab25e
Remove pip-licenses
jb3 d3914f0
Replace virtualenv with venv
jb3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,38 @@ | ||
| FROM --platform=linux/amd64 ghcr.io/owl-corp/python-poetry-base:3.12-slim | ||
| ARG python_version=3.12-slim | ||
|
|
||
| FROM python:$python_version AS builder | ||
| COPY --from=ghcr.io/astral-sh/uv:0.7 /uv /bin/ | ||
|
|
||
| ENV UV_COMPILE_BYTECODE=1 \ | ||
| UV_LINK_MODE=copy | ||
|
|
||
| # Install project dependencies with build tools available | ||
| WORKDIR /build | ||
| RUN pip install --no-cache-dir --upgrade pip setuptools wheel \ | ||
| && python -m venv .venv | ||
|
|
||
| RUN --mount=type=cache,target=/root/.cache/uv \ | ||
| --mount=type=bind,source=uv.lock,target=uv.lock \ | ||
| --mount=type=bind,source=pyproject.toml,target=pyproject.toml \ | ||
| uv sync --frozen --no-dev | ||
|
|
||
| # ------------------------------------------------------------------------------- | ||
|
|
||
| FROM python:$python_version | ||
|
|
||
| # Define Git SHA build argument for sentry | ||
| ARG git_sha="development" | ||
| ENV GIT_SHA=$git_sha | ||
|
|
||
| # Install project dependencies | ||
| WORKDIR /bot | ||
| COPY pyproject.toml poetry.lock ./ | ||
| RUN poetry install --without dev | ||
| # Install dependencies from build cache | ||
| # .venv not put in /app so that it doesn't conflict with the dev | ||
| # volume we use to avoid rebuilding image every code change locally | ||
| COPY --from=builder /build /build | ||
| ENV PATH="/build/.venv/bin:$PATH" | ||
|
|
||
| # Copy the source code in last to optimize rebuilding the image | ||
| WORKDIR /bot | ||
| COPY . . | ||
|
|
||
| ENTRYPOINT ["poetry"] | ||
| CMD ["run", "python", "-m", "bot"] | ||
| ENTRYPOINT ["python", "-m"] | ||
| CMD ["bot"] | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're doing bind mounts to avoid copying the files into the image, which would affect the build cache?