Conversation
ChrisLovering
approved these changes
Jul 27, 2025
Member
ChrisLovering
left a comment
ChrisLovering
left a comment
There was a problem hiding this comment.
target-version in the linting section of pyproject needs updating too, but looks good
MarkKoz
approved these changes
Jul 28, 2025
wookie184
requested changes
Jul 28, 2025
Contributor
wookie184
left a comment
wookie184
left a comment
There was a problem hiding this comment.
There are some new warnings in the test CI
tests/bot/exts/test_cogs.py::CommandNameTests::test_names_dont_shadow
/home/runner/work/bot/bot/bot/exts/utils/extensions.py:29: FutureWarning: functools.partial will be a method descriptor in future Python versions; wrap it in enum.member() if you want to preserve the old behavior
RELOAD = functools.partial(Bot.reload_extension)
The fix should be the same as for lancebot python-discord/sir-lancebot@2a42669
Modified as per FutureWarning
wookie184
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades Dockerfile & pyproject.toml to use 3.13.
Tested locally, bot starts without issue.