Fix off-by-one error in MAXIMUM_REMINDERS check

[oliveman-au]

MAXIMUM_REMINDERS is set to 5 and the delete command docstring confirms the limit is 5, but the check uses > instead of >=, meaning users can actually create 6 reminders before being blocked.

Changed > MAXIMUM_REMINDERS to >= MAXIMUM_REMINDERS so the limit is enforced correctly.

[L3viathan]

The off-by-one error fix seems fine, but the other hunk seems unrelated (and parts of it are already in another PR).

[oliveman-au]

The off-by-one error fix seems fine, but the other hunk seems unrelated (and parts of it are already in another PR).

reproduced this locally - you can see 6 reminders were created before the bot blocked a 7th. page 1 shows reminders 8326-8328 and page 2 shows 8329-8331, all created before hitting the limit. the 7th attempt got blocked when it should have been the 6th.

[oliveman-au]

The off-by-one error fix seems fine, but the other hunk seems unrelated (and parts of it are already in another PR).

yeah sorry about that, the branch was accidentally built on top of the jump_url fix. the only intentional change here is the >= fix, the other hunk is already covered in #3496

[lemonsaurus]

@oliveman-au This PR should be rebased on main so it only contains exactly the fix you're describing, and not this unrelated chunk.

Make sure that all your branches are always based on main, not on other branches you are working on. Every PR should contain an atomic change, not be mixed with other changes.

[jb3]

Should be combined into one PR across all reminder functionality.