Fix AttributeError in maybe_archive_idle_post when post is missing#3498
Merged
wookie184 merged 2 commits intopython-discord:mainfrom May 4, 2026
Conversation
Contributor
|
LGTM |
jb3
approved these changes
May 3, 2026
wookie184
approved these changes
May 4, 2026
Contributor
wookie184
left a comment
wookie184
left a comment
There was a problem hiding this comment.
Good find, thanks for the PR 🚀
I checked and confirmed that this is a bug that was being triggered in production, created+linked a sentry issue just for added context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
get_or_fetch_channelraisesdiscord.HTTPException, the except block referencespostandpost.id— butpostwas never assigned since the exception occurred before the assignment completed. This causes anAttributeError: 'int' object has no attribute 'id', meaning the error handler itself crashes instead of recovering gracefully.Fixed by replacing
postandpost.idwithpost_idin the log line, which is the integer that was passed into the function.