Add Alloy support to Rocky nodes#664
Open
jb3 wants to merge 3 commits into
Open
Conversation
Member
jb3
commented
May 25, 2026
- Add Rocky repositories for Grafana projects, so we can install Alloy
- Set new binary permissions for Alloy to allow reading of all files regardless of read permissions
- Enable live debugging features in Alloy
- Pull out systemd unit as a new label for better filtering in Loki
bd6cd24 to
dc70e54
Compare
jchristgit
requested changes
May 25, 2026
| # We need to add cap_dac_read_search=+ep to the Alloy binary. | ||
|
|
||
| - name: Get Alloy binary path | ||
| command: "which alloy" |
Contributor
There was a problem hiding this comment.
Do you know if ansible sanitizes PATH (or does not preserve it from the user it's escalating from)? If not, something malicious modifying PATH on the profile of whoever deploys could cause this to set cap_dac_read_search on the binary.
| - role::alloy | ||
|
|
||
| - name: Set capabilities on the Alloy binary | ||
| command: "setcap cap_dac_read_search=ep {{ alloy_binary_path.stdout }}" |
Contributor
There was a problem hiding this comment.
Can't this be done via systemd?
man systemd.exec, see AmbientCapabilities. That way we can remove this whole dance and just set it in the service, no?
Comment on lines
+7
to
+10
| livedebugging { | ||
| enabled = true | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Does this not expose sensitive information in some way that I'm missing? Judging by the Grafana docs, this relates to the Alloy UI. I haven't followed the deployment - do we expose that somewhere?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.