Skip to content

Commit 6511c69

Browse files
committed
Fetch GitHub IDs a different (less efficient, sadly) way
1 parent 9ba0dcb commit 6511c69

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

arthur/apis/directory/keycloak.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,13 +53,13 @@ def all_github_ids() -> list[str]:
5353
"""Fetch all GitHub IDs from Keycloak."""
5454
client = create_client()
5555

56-
users = client.get_users({"enabled": True, "search": "*"})
57-
56+
users = client.get_users()
5857
github_ids = []
58+
5959
for user in users:
60-
for ident in user["federatedIdentities"]:
60+
user_details = client.get_user(user["id"])
61+
for ident in user_details["federatedIdentities"]:
6162
if ident["identityProvider"] == "github":
62-
github_ids.append(ident["userId"])
63-
break
63+
github_ids.append(ident["userId"]) # noqa: PERF401
6464

6565
return github_ids

0 commit comments

Comments
 (0)