Add mapping for LDAP group to github team slugs

Author: ChrisLovering

arthur/constants.py

@@ -1,16 +1,26 @@
 """Constants, primarily used for LDAP enrollment preferences."""
 
+from typing import TypedDict
+
+
+class LDAPGroupMapping(TypedDict):
+    """Mapping of an LDAP group to its Discord role ID and GitHub team ID."""
+
+    discord_role_id: int
+    github_team_slug: str
+
+
 # Users are only checked for enrollment if they have this role. This doesn't grant them any
 # permissions, it is for performance to avoid iterating roles for every other user in the guild.
 LDAP_BASE_STAFF_ROLE = 267630620367257601
 
-# This is a mapping of LDAP groups to Discord roles. It is used to determine which users should be
-# eligible for LDAP enrollment.
-LDAP_ROLE_MAPPING = {
-    "devops": 409416496733880320,
-    "administrators": 267628507062992896,
-    "moderators": 267629731250176001,
-    "coredevs": 587606783669829632,
-    "events": 787816728474288181,
-    "directors": 267627879762755584,
+# This is a mapping of LDAP groups to Discord role IDs and GitHub team IDs. It is used to determine
+# which users should be eligible for LDAP enrollment.
+LDAP_ROLE_MAPPING: dict[str, LDAPGroupMapping] = {
+    "devops": {"discord_role_id": 409416496733880320, "github_team_slug": "devops"},
+    "administrators": {"discord_role_id": 267628507062992896, "github_team_slug": "admins"},
+    "moderators": {"discord_role_id": 267629731250176001, "github_team_slug": "moderators"},
+    "coredevs": {"discord_role_id": 587606783669829632, "github_team_slug": "core-developers"},
+    "events": {"discord_role_id": 787816728474288181, "github_team_slug": "events"},
+    "directors": {"discord_role_id": 267627879762755584, "github_team_slug": "directors"},
 }

arthur/exts/directory/ldap.py

@@ -330,8 +330,8 @@ async def cog_load(self) -> None:  # noqa: C901, PLR0912
             await channel.send(bootstrap_message, view=BootstrapView(self))
 
         # Validate all enrolled roles can see the channel
-        for role_id in LDAP_ROLE_MAPPING.values():
-            role = channel.guild.get_role(role_id)
+        for mapping in LDAP_ROLE_MAPPING.values():
+            role = channel.guild.get_role(mapping["discord_role_id"])
 
             if not role:
                 continue
@@ -361,8 +361,8 @@ def _user_groups(user: discord.Member) -> list[str]:
         """Return the groups a user is enrolled in."""
         return [
             role
-            for role, discord_role_id in LDAP_ROLE_MAPPING.items()
-            if discord_role_id in [r.id for r in user.roles]
+            for role, mapping in LDAP_ROLE_MAPPING.items()
+            if mapping["discord_role_id"] in [r.id for r in user.roles]
         ]
 
     async def get_user_diff(
@@ -373,7 +373,7 @@ async def get_user_diff(
         users = await ldap.find_users()
         ldap_discord_id_map = {user.employee_number: user for user in users}
 
-        enrolled_roles = set(LDAP_ROLE_MAPPING.values())
+        enrolled_roles = {mapping["discord_role_id"] for mapping in LDAP_ROLE_MAPPING.values()}
 
         base_role = guild.get_role(LDAP_BASE_STAFF_ROLE)