Add helpers to ldap sync

Author: ChrisLovering

arthur/constants.py

@@ -13,7 +13,7 @@ class LDAPGroupMapping(TypedDict):
 # This is a mapping of LDAP groups to Discord role IDs and GitHub team IDs. It is used to determine
 # which users should be eligible for LDAP enrollment.
 LDAP_ROLE_MAPPING: dict[str, LDAPGroupMapping] = {
-    # "helpers": {"discord_role_id": 267630620367257601, "github_team_slug": "helpers"},  # noqa: ERA001
+    "helpers": {"discord_role_id": 267630620367257601, "github_team_slug": "helpers"},
     "devops": {"discord_role_id": 409416496733880320, "github_team_slug": "devops"},
     "administrators": {"discord_role_id": 267628507062992896, "github_team_slug": "admins"},
     "moderators": {"discord_role_id": 267629731250176001, "github_team_slug": "moderators"},
@@ -24,4 +24,4 @@ class LDAPGroupMapping(TypedDict):
 
 # Users are only checked for enrollment if they have this role. This doesn't grant them any
 # permissions, it is for performance to avoid iterating roles for every other user in the guild.
-HELPER_ROLE_ID = 267630620367257601  # LDAP_ROLE_MAPPING["helpers"]["discord_role_id"]
+HELPER_ROLE_ID = LDAP_ROLE_MAPPING["helpers"]["discord_role_id"]

arthur/exts/github/management.py

@@ -6,6 +6,7 @@
 
 from arthur.apis.github import GitHubError, add_member_to_team, remove_org_member
 from arthur.config import CONFIG
+from arthur.constants import LDAP_ROLE_MAPPING
 
 if TYPE_CHECKING:
     from arthur.bot import KingArthurTheTerrible
@@ -35,7 +36,7 @@ async def github(self, ctx: Context) -> None:
     async def add_team_member(self, ctx: Context, username: str) -> None:
         """Add a user to the default GitHub team."""
         try:
-            await add_member_to_team(username, "helpers")
+            await add_member_to_team(username, LDAP_ROLE_MAPPING["helpers"]["github_team_slug"])
             await ctx.send(f":white_check_mark: Successfully invited {username} to the staff team.")
         except GitHubError as e:
             await ctx.send(f":x: Failed to add {username} to the staff team: {e}")