Add .quote daily and .quote random command to retrieve quotes from zenquotes.io api#1707
Merged
Conversation
…and the daily quote from the zenquotes.io api respectively
jb3
requested changes
Nov 4, 2025
Member
jb3
left a comment
There was a problem hiding this comment.
These commands should be in a group together (e.g. .quote random and .quote daily).
See review comments, but additionally:
- The API usage is metered, so you should cache the daily quote for a period instead of making frequent requests.
- The ZenQuotes license mandates that you provide attribution when you use quotes from their API on their free plan (see https://docs.zenquotes.io/zenquotes-documentation/#use-limits). We need to either do this or find an API that does not require attribution (use an embed if you decide to add attribution).
jb3
reviewed
Nov 4, 2025
Contributor
Author
|
Thanks for the detailed review, I'll work on implementing these changes and push as soon as possible. |
jb3
requested changes
Nov 6, 2025
Member
jb3
left a comment
There was a problem hiding this comment.
Awesome! Thanks for making those changes, looks much cleaner than the original implementation. Also, nice work integrating Redis for the caching.
Few more feedback points below:
Contributor
Author
|
I have implemented these changes. |
jb3
requested changes
Nov 7, 2025
Member
jb3
left a comment
There was a problem hiding this comment.
The uv.lock changes can be reverted now as well since aiohttp is unpinned.
jb3
approved these changes
Nov 10, 2025
Member
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Relevant Issues
Closes #1706
Description
bot/utils/quote.pyfor API requests using bot's HTTP session..quote dailyand.quote randomcommands inbot/exts/fun/fun.pyto retrieve the daily quote and random quotes from zenquotes.io API respectively.Did you: