Add Support for aliases repositories & default org in .gh repo command#1711
Conversation
Sacul0457
left a comment
There was a problem hiding this comment.
It's good practice to cancel the cog when unloading. I'm believe it's done here too (not too sure), but it can lead to some problems because a task isn't automatically cancelled when the cog is unloaded.
async def cog_unload(self):
self.refresh_repos.cancel()
It wasn't done, I had no idea that was best practice but I have implemented it now. |
Sacul0457
left a comment
There was a problem hiding this comment.
Thx for addressing the reviews earlier, these are just some minor ones
So far, it looks good to me, I'll review once more after this change
onerandomusername
left a comment
There was a problem hiding this comment.
So far liking the general implementation. These comments are more about code style. I previously began a review but it looks like GitHub ate my comments so I might have more to add later.
Co-authored-by: Sacul <183588943+Sacul0457@users.noreply.github.com>
…tent throughout Co-authored-by: Sacul <183588943+Sacul0457@users.noreply.github.com>
|
this is shaping up nicely, I don't have any more changes:) |
Co-authored-by: z <me@arielle.codes>
Relevant Issues
Closes #1710
Description
bot/resources/utilities/stored_repos.json.gh repoto support repository aliasesI Did: