Fix n+1 queries#1633
Open
ChrisLovering wants to merge 3 commits into
Open
Conversation
Since the role validator was in the model, a query to the roles table had to be ran for each row returned by the user query. Moving this validation to the serialiser allowed all roles to be validated in the same query as the fetch. Since the validation is done at the serialiser level, this removed the need for the validators to be in the model at all.
✅ Deploy Preview for pydis-static ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
coverage: 100.0%. remained the same — fix-n+1-queries into main |
MarkKoz
reviewed
Jul 7, 2026
| depth = 1 | ||
| list_serializer_class = UserListSerializer | ||
|
|
||
| def validate_roles(self, roles: list[int]) -> list[int]: |
Member
Author
There was a problem hiding this comment.
The existing user test will cover this, even tough it's moved from model to serialiser.
https://github.com/python-discord/site/blob/main/pydis_site/apps/api/tests/test_users.py#L110-L122
However, I have noticed it doens't assert the response detail, nor do we have coverage for PATCH (single, nor bulk), so have added all of that in f7b8d0c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.