Allow linking to a specific card#148
Conversation
|
two things missing:
|
|
Unfortunately the CI will fail because it only properly works on branches of this repo, I will open a PR to fix it. |
I with manual testing I find a |
|
Will that work if applied on the card div, not on the row? |
|
When I tested, I added it to the FYI, update the branch and the CI will go green. |
|
Looks nice on browser and (emulated) mobile. Let me know if the last commit should be a separate PR (I assume you’ll squash merge this) |
|
Some thoughts, as for the last commit, I suggest removing that from this PR, I think it would also be better to have the full name rather than the language code. Yes, I will squash. As for the linking, I can confirm it works fine on FireFox on Linux and on iOS with Safari. However, I think the bold blue text is now too "loud" for what it does, although this is quite difficult accessibility-wise I must admit. How about an icon that appears on hover/focus next to the heading, for example, something like like so? |
|
I tried this: .card-title a:focus::after, .card-title a:hover::after {
content: " 🔗";
}but didn’t like it. Another accessiblity rule: people decide to click on something before they move their mouse or finger, so essential information should not be available only on hover/focus. The effect in your video is nice, but not discoverable enough. What about always having |
This reverts commit c8d8c49.
|
I propose suggestions in https://github.com/merwok-forks/py-docs-translations-dashboard/pull/1. |
|
Replaced by #156 |


fixes #136