Skip to content

Always provide a translated name#170

Merged
m-aciek merged 3 commits intomainfrom
autonyms-galore!
Mar 22, 2026
Merged

Always provide a translated name#170
m-aciek merged 3 commits intomainfrom
autonyms-galore!

Conversation

@StanFromIreland
Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland commented Mar 22, 2026

@StanFromIreland StanFromIreland requested a review from m-aciek March 22, 2026 17:37
Copy link
Copy Markdown
Collaborator

@m-aciek m-aciek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I've left some minor improvements suggestions. 10MB Babel may seem as a big dependency for translation of six language names, but that's just classic modern software 🙃 😉

Comment thread translated_names.py Outdated
Comment thread translated_names.py Outdated
Comment thread translated_names.py
@StanFromIreland StanFromIreland requested a review from m-aciek March 22, 2026 22:09
@StanFromIreland
Copy link
Copy Markdown
Member Author

10MB Babel may seem as a big dependency for translation of six language names, but that's just classic modern software 🙃 😉

It is painful, but it's only a dashboard... and it's always good to dream big, maybe it'll be a few more some day;-)

@StanFromIreland StanFromIreland self-assigned this Mar 22, 2026
Comment thread tests/test_translated_names.py Outdated
Co-authored-by: Maciej Olko <maciej.olko@gmail.com>
@m-aciek m-aciek merged commit 2b9b320 into main Mar 22, 2026
3 of 4 checks passed
@m-aciek m-aciek deleted the autonyms-galore! branch March 22, 2026 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants