Skip to content

Update contributing links for zh-tw and fr languages #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-aciek merged 2 commits into from
Mar 23, 2026
Merged

Update contributing links for zh-tw and fr languages #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e51d972
Update contributing links for zh-tw and fr languages
m-aciek Mar 22, 2026
63f5360
Update test expectation
m-aciek Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contribute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
custom_contributing_links: dict[str, str] = {
'es': 'https://python-docs-es.readthedocs.io/page/CONTRIBUTING.html',
'ko': 'https://www.flowdas.com/pages/python-docs-ko.html',
'zh-tw': 'https://github.com/python/python-docs-zh-tw/blob/3.13/README.rst#%E5%8F%83%E8%88%87%E7%BF%BB%E8%AD%AF',
'fr': 'https://git.afpy.org/AFPy/python-docs-fr/src/branch/3.13/CONTRIBUTING.rst',
'zh-tw': 'https://github.com/python/python-docs-zh-tw/blob/3.14/README.rst#id2',
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Mar 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep zh-tw test fixture in sync with link change

Updating custom_contributing_links['zh-tw'] here makes the test suite fail because tests/test_contribute.py still asserts the previous 3.13 URL in test_get_contrib_link, while .github/workflows/run-tests.yml runs python -m unittest discover -s tests on every PR/push. This creates a deterministic CI failure for this commit until the expected test value is updated alongside the new link.

Useful? React with 👍 / 👎.

'fr': 'https://git.afpy.org/AFPy/python-docs-fr/src/branch/3.14/CONTRIBUTING.rst',
'id': 'https://github.com/python/python-docs-id/blob/3.14/README.md#berkontribusi-untuk-menerjemahkan',
'tr': 'https://github.com/python/python-docs-tr/blob/3.12/README.md#%C3%A7eviriye-katk%C4%B1da-bulunmak',
'el': 'https://github.com/python/python-docs-el/blob/3.14/CONTRIBUTING.md',
Expand Down
2 changes: 1 addition & 1 deletion tests/test_contribute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def test_get_contrib_link(self):
(
'zh-tw',
None,
'https://github.com/python/python-docs-zh-tw/blob/3.13/README.rst#%E5%8F%83%E8%88%87%E7%BF%BB%E8%AD%AF',
'https://github.com/python/python-docs-zh-tw/blob/3.14/README.rst#id2',
),
(
'id',
Expand Down
Loading