-
Notifications
You must be signed in to change notification settings - Fork 5
HTML/Jinja lint & format #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
m-aciek
wants to merge
11
commits into
main
Choose a base branch
from
jinja-lint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
17063f9
Add new linter
m-aciek 4562abf
reformat
m-aciek 2ecce5d
add meta keywords, move styles to stylesheet, add height and width fo…
m-aciek 2d7e347
bump style cache version
m-aciek 51369e8
update logo dimensions in base.html and clean up CSS
m-aciek 272d43e
endblock name
m-aciek 6b88883
move link color on card to the stylesheet, quotes, centering, blocks
m-aciek bd4bd65
use spaceless tags inside attribute values
m-aciek bc5c228
add indentation setting to djlint configuration
m-aciek 6ee38e5
reformat
m-aciek dbbffd2
Merge branch 'main' into jinja-lint
m-aciek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| ignore="J018" | ||
| indent=2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,43 +1,43 @@ | ||
| {% extends "base.html.jinja" %} | ||
|
|
||
| {% block main %} | ||
| <table> | ||
| <thead> | ||
| <tr> | ||
| <th>language</th> | ||
| <th>branch</th> | ||
| <th>last updated</th> | ||
| <th>build warnings*</th> | ||
| <th>lint failures</th> | ||
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| {% for project, metadata in build_details | sort(attribute='0.completion') | reverse %} | ||
| {% if project.repository %} | ||
| <tr> | ||
| <td data-label="language">{{ project.language.name }} ({{ project.language.code }})</td> | ||
| <td data-label="branch">{{ project.branch }}</td> | ||
| <td data-label="updated">{{ metadata[2].strftime('%Y/%m/%d %T') if metadata[2] else '' }}</td> | ||
| <td data-label="warnings"> | ||
| {% if project.completion %} | ||
| <a href="warnings-{{ project.language.code }}.txt">{{ metadata[0] }}</a> | ||
| {% else %} | ||
| {{ metadata[0] }} | ||
| {% endif %} | ||
| </td> | ||
| <td data-label="lint"> | ||
| {% if project.completion %} | ||
| <a href="warnings-lint-{{ project.language.code }}.txt">{{ metadata[1] }}</a> | ||
| {% else %} | ||
| {{ metadata[1] }} | ||
| {% endif %} | ||
| </td> | ||
| </tr> | ||
| {% endif %} | ||
| {% endfor %} | ||
| </tbody> | ||
| </table> | ||
|
|
||
| <p>* number of Sphinx build process warnings</p> | ||
| <p>Last updated at {{ generation_time.strftime('%A, %-d %B %Y, %-H:%M:%S %Z') }} (in {{ duration // 60 }}:{{ "{:02}".format(duration % 60) }} minutes).</p> | ||
| {% endblock %} | ||
| <table> | ||
| <thead> | ||
| <tr> | ||
| <th>language</th> | ||
| <th>branch</th> | ||
| <th>last updated</th> | ||
| <th>build warnings*</th> | ||
| <th>lint failures</th> | ||
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| {% for project, metadata in build_details | sort(attribute='0.completion') | reverse %} | ||
| {% if project.repository %} | ||
| <tr> | ||
| <td data-label="language">{{ project.language.name }} ({{ project.language.code }})</td> | ||
| <td data-label="branch">{{ project.branch }}</td> | ||
| <td data-label="updated">{{ metadata[2].strftime("%Y/%m/%d %T") if metadata[2] else '' }}</td> | ||
| <td data-label="warnings"> | ||
| {% if project.completion %} | ||
| <a href="warnings-{{ project.language.code }}.txt">{{ metadata[0] }}</a> | ||
| {% else %} | ||
| {{ metadata[0] }} | ||
| {% endif %} | ||
| </td> | ||
| <td data-label="lint"> | ||
| {% if project.completion %} | ||
| <a href="warnings-lint-{{ project.language.code }}.txt">{{ metadata[1] }}</a> | ||
| {% else %} | ||
| {{ metadata[1] }} | ||
| {% endif %} | ||
| </td> | ||
| </tr> | ||
| {% endif %} | ||
| {% endfor %} | ||
| </tbody> | ||
| </table> | ||
| <p>* number of Sphinx build process warnings</p> | ||
| <p> | ||
| Last updated at {{ generation_time.strftime("%A, %-d %B %Y, %-H:%M:%S %Z") }} (in {{ duration // 60 }}:{{ "{:02}".format(duration % 60) }} minutes). | ||
| </p> | ||
| {% endblock main %} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a dead project, no releases since 2024, are there no alternatives? It seems to work alright currently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My quick research implied it is mature and stable, and there's no better alternative. It looks stagnant on PyPI, but the repo still receives commits. The GitHub project had updates as recently as Nov 2025, and the docs were updated in 2026, which indicates some ongoing maintenance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact they have Renovate set up to do updates multiple times a day, and automerge them without human review, is a bit odd:
https://github.com/djlint/djLint/commits/master/
Also no cooldown, so a very good way to be among the very first to be exposed to a new vulnerability...
https://blog.yossarian.net/2025/11/21/We-should-all-be-using-dependency-cooldowns
We're on a pinned tag not on
master, which helps, but tags are immutable and a vuln could rewrite the tags.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've opened an issue with a suggestion to add the cooldown: djlint/djLint#1783.
It's only library like that that offers an autoformatter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing as the whole litellm thing happened the day after Hugo’s message, I think we should wait with this PR till they make such changes.