Skip to content

Add a dark mode#174

Merged
m-aciek merged 1 commit intomainfrom
dark-mode
Mar 25, 2026
Merged

Add a dark mode#174
m-aciek merged 1 commit intomainfrom
dark-mode

Conversation

@StanFromIreland
Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland commented Mar 23, 2026

@StanFromIreland StanFromIreland requested a review from m-aciek March 23, 2026 18:02
Copy link
Copy Markdown
Collaborator

@m-aciek m-aciek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool, thanks 🚀 Though I have a (small?) feature request. Could the toggle have a third state, which would toggle the theme to be OS-driven instead of being static in the localStorage? It would make it possible to reset the the default behaviour, that's visible for people that switch between light/dark depending on the time of day (me included).

For example Furo has this third state: https://packaging.python.org/en/latest/

@StanFromIreland
Copy link
Copy Markdown
Member Author

I'm afraid I can't get the toggle on the Furo website to work on Linux. Maybe I/someone with access to a system where this works can do this in a follow up?

@StanFromIreland StanFromIreland requested a review from m-aciek March 24, 2026 14:10
@m-aciek m-aciek merged commit 03ab645 into main Mar 25, 2026
4 checks passed
@m-aciek m-aciek deleted the dark-mode branch March 25, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants