Conversation
The requirements were transitive, but we are using them directly, so they should be in the requirements.
| - id: mypy | ||
| additional_dependencies: [types-docutils, types-polib>=1.2.0.20250114, types-requests] | ||
|
|
||
| - repo: https://github.com/francescorubbo/deptry-pre-commit |
Member
There was a problem hiding this comment.
Hmm... It is not very popular, but from a scan of the repo it seems alright.
StanFromIreland
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #90.
The requirements were transitive, but we are using them directly, so they should be in the requirements.
Use of non-official pre-commit hook is justified by the fact that pre-commit hooks should not depend on the repository environment, as recommended by the pre-commit creator, making an independent deptry hook preferable.
📊 Dashboard preview 📊: https://python-docs-translations.github.io/dashboard/91/merge/