Skip to content

Fix all Zizmor audit findings#237

Merged
StanFromIreland merged 2 commits into
python-docs-translations:mainfrom
StanFromIreland:zizmor
Jun 1, 2026
Merged

Fix all Zizmor audit findings#237
StanFromIreland merged 2 commits into
python-docs-translations:mainfrom
StanFromIreland:zizmor

Conversation

@StanFromIreland

Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This action is deprecated and so I just removed it rather than pinning.

@rffontenelle rffontenelle left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to ask you to work on this security fix but you were faster fixing it.

I see versions in pre-commit could be updated. Does this need to be done manually or an automation (e.g. dependabot) can do it?

@StanFromIreland

Copy link
Copy Markdown
Member Author

I see versions in pre-commit could be updated. Does this need to be done manually or an automation (e.g. dependabot) can do it?

Dependabot can as of very recently: https://github.blog/changelog/2026-03-10-dependabot-now-supports-pre-commit-hooks/

We can make that a separate PR, however.

@StanFromIreland StanFromIreland merged commit 04fe8dc into python-docs-translations:main Jun 1, 2026
11 checks passed
@StanFromIreland StanFromIreland deleted the zizmor branch June 1, 2026 12:57
@m-aciek

m-aciek commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Weren't the changes too strict? https://github.com/python-docs-translations/transifex-automations/actions/runs/26776396669 the CI failed

Comment thread .github/workflows/ci.yml
with:
ref: ${{ steps.version.outputs.current }}
path: ${{ steps.version.outputs.current }}
persist-credentials: false

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fatal: could not read Username for 'https://github.com': No such device or address

possibly related to CI job failure

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should split the commit job from the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants