Lint

Author: domdfcoding

flake8_dunder_all/__init__.py

@@ -33,19 +33,23 @@
 import ast
 import sys
 from enum import Enum
-from typing import Any, Generator, Iterator, List, Optional, Sequence, Set, Tuple, Type, Union, cast
+from typing import TYPE_CHECKING, Any, Generator, Iterator, List, Optional, Sequence, Set, Tuple, Type, Union, cast
 
 # 3rd party
 import natsort
 from consolekit.terminal_colours import Fore
 from domdf_python_tools.paths import PathPlus
 from domdf_python_tools.typing import PathLike
 from domdf_python_tools.utils import stderr_writer
-from flake8.options.manager import OptionManager  # type: ignore
+from flake8.options.manager import OptionManager  # type: ignore[import]
 
 # this package
 from flake8_dunder_all.utils import find_noqa, get_docstring_lineno, mark_text_ranges
 
+if TYPE_CHECKING:
+	# stdlib
+	from argparse import Namespace
+
 __author__: str = "Dominic Davis-Foster"
 __copyright__: str = "2020 Dominic Davis-Foster"
 __license__: str = "MIT"
@@ -365,7 +369,7 @@ def add_options(cls, option_manager: OptionManager) -> None:  # noqa: D102  # pr
 				)
 
 	@classmethod
-	def parse_options(cls, options):  # noqa: D102  # pragma: no cover
+	def parse_options(cls, options: "Namespace") -> None:  # noqa: D102  # pragma: no cover
 		# note: this sets the option on the class and not the instance
 		cls.dunder_all_alphabetical = AlphabeticalOptions(options.dunder_all_alphabetical)
 

tests/__init__.py

@@ -7,19 +7,17 @@
 # 3rd party
 import pytest
 from coincidence.regressions import AdvancedFileRegressionFixture
-from common import (
-		if_type_checking_else_source,
-		if_type_checking_source,
-		if_type_checking_try_finally_source,
-		if_type_checking_try_source
-		)
 from consolekit.terminal_colours import Fore
 from domdf_python_tools.paths import PathPlus
 
 # this package
 from flake8_dunder_all import AlphabeticalOptions, Plugin, Visitor, check_and_add_all
 from flake8_dunder_all.utils import mark_text_ranges
 from tests.common import (
+		if_type_checking_else_source,
+		if_type_checking_source,
+		if_type_checking_try_finally_source,
+		if_type_checking_try_source,
 		mangled_source,
 		not_type_checking_if_source,
 		results,

tests/test_flake8_dunder_all.py

@@ -8,7 +8,10 @@
 from consolekit.terminal_colours import Fore
 from consolekit.testing import CliRunner, Result
 from domdf_python_tools.paths import PathPlus
-from test_flake8_dunder_all import (
+
+# this package
+from flake8_dunder_all.__main__ import main
+from tests.test_flake8_dunder_all import (
 		mangled_source,
 		testing_source_a,
 		testing_source_b,
@@ -25,9 +28,6 @@
 		testing_source_l
 		)
 
-# this package
-from flake8_dunder_all.__main__ import main
-
 
 @pytest.mark.parametrize(
 		"source, members, ret",