Remove checks for typing.NamedTuple as it disallows explicitly setting __slots__

Author: domdfcoding

doc-source/usage.rst

@@ -13,7 +13,6 @@ Flake8 codes
 	SLOT000
 	SLOT001
 	SLOT002
-	SLOT003
 
 For subclasses of immutable types it is recommended to use ``__slots__ = ()`` to keep the memory usage down.
 For subclasses of :class:`str` it is possible to define other variables which may be set on instances. For example:
@@ -22,7 +21,7 @@ For subclasses of :class:`str` it is possible to define other variables which ma
 
 	class MyString(str):
 
-		__slots__ = ("a_variable")
+		__slots__ = ("a_variable", )
 
 which will allow a value to be assigned to ``a_variable``.
 

flake8_slots/__init__.py

@@ -32,20 +32,19 @@
 
 # 3rd party
 import flake8_helper
-from domdf_python_tools.paths import PathPlus
 
 __author__: str = "Dominic Davis-Foster"
 __copyright__: str = "2020-2021 Dominic Davis-Foster"
 __license__: str = "MIT License"
 __version__: str = "0.1.0"
 __email__: str = "dominic@davis-foster.co.uk"
 
-__all__ = ["Visitor", "Plugin", "SLOT000", "SLOT001", "SLOT002", "SLOT003"]
+__all__ = ["Visitor", "Plugin", "SLOT000", "SLOT001", "SLOT002"]
 
 SLOT000 = "SLOT000 Define __slots__ for subclasses of str"
 SLOT001 = "SLOT001 Define __slots__ for subclasses of tuple"
 SLOT002 = "SLOT002 Define __slots__ for subclasses of collections.namedtuple"
-SLOT003 = "SLOT003 Define __slots__ for subclasses of typing.NamedTuple"
+# SLOT003 # Don't reuse
 
 # TODO: custom immutable types - config option and SLOT004
 
@@ -101,9 +100,8 @@ def visit_ClassDef(self, node: ast.ClassDef):  # noqa: D102
 			is_tuple = False
 
 		is_collections_namedtuple = "namedtuple" in bases or "collections.namedtuple" in bases  # SLOT002
-		is_typing_namedtuple = "NamedTuple" in bases or "typing.NamedTuple" in bases  # SLOT003
 
-		if not any([is_str, is_tuple, is_collections_namedtuple, is_typing_namedtuple]):
+		if not any([is_str, is_tuple, is_collections_namedtuple]):
 			return
 
 		body_visitor = ClassBodyVisitor()
@@ -116,8 +114,6 @@ def visit_ClassDef(self, node: ast.ClassDef):  # noqa: D102
 				self.report_error(node, SLOT001)
 			if is_collections_namedtuple:
 				self.report_error(node, SLOT002)
-			if is_typing_namedtuple:
-				self.report_error(node, SLOT003)
 
 
 class Plugin(flake8_helper.Plugin[Visitor]):

requirements.txt

@@ -1,3 +1,2 @@
-domdf-python-tools>=1.8.0
 flake8>=3.7
 flake8-helper>=0.1.1

tests/test_errors.py

@@ -5,7 +5,7 @@
 import pytest
 
 # this package
-from flake8_slots import SLOT000, SLOT001, SLOT002, SLOT003, Plugin, Visitor
+from flake8_slots import SLOT000, SLOT001, SLOT002, Plugin, Visitor
 
 string_a = "\nclass String(str): pass"
 string_b = "import builtins\nclass String(builtins.str): pass"
@@ -17,20 +17,6 @@
 namedtuple_a = "import collections\nclass Person(collections.namedtuple('foo', 'name, age')): pass"
 namedtuple_b = "from collections import namedtuple\nclass Person(namedtuple('foo', 'name, age')): pass"
 
-typing_namedtuple_a = """\
-import typing
-class Person(typing.NamedTuple):
-	name: str
-	age: int
-"""
-
-typing_namedtuple_b = """\
-from typing import NamedTuple
-class Person(NamedTuple):
-	name: str
-	age: int
-"""
-
 sources = pytest.mark.parametrize(
 		"source, error",
 		[
@@ -43,8 +29,6 @@ class Person(NamedTuple):
 				(typing_tuple_c, SLOT001),
 				(namedtuple_a, SLOT002),
 				(namedtuple_b, SLOT002),
-				(typing_namedtuple_a, SLOT003),
-				(typing_namedtuple_b, SLOT003),
 				]
 		)
 

tests/test_good_code.py

@@ -26,31 +26,13 @@ class Person(namedtuple('foo', 'name, age')):
 typing_namedtuple_a = """\
 import typing
 class Person(typing.NamedTuple):
-	__slots__ = ()
 	name: str
 	age: int
 """
 
 typing_namedtuple_b = """\
 from typing import NamedTuple
 class Person(NamedTuple):
-	__slots__ = ()
-	name: str
-	age: int
-"""
-
-typing_namedtuple_c = """\
-from typing import NamedTuple
-class Person(NamedTuple):
-	__slots__: Tuple[str] = ()
-	name: str
-	age: int
-"""
-
-typing_namedtuple_d = """\
-from typing import NamedTuple
-class Person(NamedTuple):
-	__slots__: List[str] = []
 	name: str
 	age: int
 """
@@ -76,8 +58,6 @@ class Compound(Counter):
 				namedtuple_c,
 				typing_namedtuple_a,
 				typing_namedtuple_b,
-				typing_namedtuple_c,
-				typing_namedtuple_d,
 				mutable,
 				]
 		)