Merge pull request nhoad#7 from SebDieBln/Fix_classmethods_ignore_first_unused_argument

Fix ignores first unused argument in classmethods

Author: nhoad

flake8_unused_arguments.py

@@ -70,7 +70,7 @@ def run(self) -> Iterable[LintResult]:
             if self.ignore_stubs and is_stub_function(function):
                 continue
 
-            for i, argument in enumerate(get_unused_arguments(function)):
+            for i, argument in get_unused_arguments(function):
                 name = argument.arg
                 if self.ignore_variadic_names:
                     if function.args.vararg and function.args.vararg.arg == name:
@@ -97,17 +97,17 @@ def run(self) -> Iterable[LintResult]:
                 yield (line_number, offset, text, check)
 
 
-def get_unused_arguments(function: FunctionTypes) -> List[ast.arg]:
+def get_unused_arguments(function: FunctionTypes) -> List[Tuple[int, ast.arg]]:
     """Generator that yields all of the unused arguments in the given function."""
-    arguments = get_arguments(function)
+    arguments = list(enumerate(get_arguments(function)))
 
     class NameFinder(NodeVisitor):
         def visit_Name(self, name: ast.Name) -> None:
             nonlocal arguments
             if isinstance(name.ctx, Store):
                 return
 
-            arguments = [arg for arg in arguments if arg.arg != name.id]
+            arguments = [(arg_index, arg) for arg_index, arg in arguments if arg.arg != name.id]
 
     NameFinder().visit(function)
 

test_unused_arguments.py

@@ -52,7 +52,7 @@ def internal():
 def test_get_unused_arguments(function, expected_names):
     from flake8_unused_arguments import get_unused_arguments
 
-    argument_names = [a.arg for a in get_unused_arguments(get_function(function))]
+    argument_names = [a.arg for _, a in get_unused_arguments(get_function(function))]
     print(argument_names)
     print(expected_names)
     assert argument_names == expected_names
@@ -160,6 +160,11 @@ def foo(self):
     def foo(cls):
         pass
     """, {}, []),
+    ("""
+    @classmethod
+    def foo(cls, bar):
+        use(cls)
+    """, {}, [(3, 13, "U100 Unused argument 'bar'", 'unused argument')]),
 ])
 def test_integration(function, options, expected_warnings):
     from flake8_unused_arguments import Plugin