Correctly handle and ast.Constant objects where the values aren't strings.

Author: domdfcoding

flake8_strftime/__init__.py

@@ -53,7 +53,7 @@ def __init__(self) -> None:
 		self.errors: List[Tuple[int, int, str]] = []
 		self._from_imports: Dict[str, str] = {}
 
-	if sys.version_info < (3, 8):  # pragma: no cover (<PY38)
+	if sys.version_info < (3, 8):  # pragma: no cover (PY38+)
 
 		def visit_Str(self, node: ast.Str):
 			"""
@@ -65,7 +65,7 @@ def visit_Str(self, node: ast.Str):
 			self._check_linux(node)
 			self._check_windows(node)
 
-	else:  # pragma: no cover (PY38+)
+	else:  # pragma: no cover (<PY38)
 
 		def visit_Constant(self, node: ast.Constant):
 			"""
@@ -74,6 +74,9 @@ def visit_Constant(self, node: ast.Constant):
 			:param node: The node being visited
 			"""
 
+			if not isinstance(node.s, (str, bytes)):
+				return
+
 			self._check_linux(node)
 			self._check_windows(node)
 

tests/flake8_strftime_test.py

@@ -1,6 +1,9 @@
 # stdlib
 import ast
 
+# 3rd party
+import pytest
+
 # this package
 from flake8_strftime import Plugin
 
@@ -31,3 +34,22 @@ def test_windows_specific():
 		"1:22: STRFTIME002 Windows-specific strftime code used.",
 		"1:26: STRFTIME002 Windows-specific strftime code used.",
 		}
+
+
+@pytest.mark.parametrize(
+		"source",
+		[
+				"test_none = None",
+				"test_ellipsis = ...",
+				"test_int = 42",
+				"test_float = 1.0",
+				"test_list = [1, 2, 3]",
+				"test_tuple = (1, 2, 3)",
+				"test_set = {1, 2, 3}",
+				'test_dict = {"a": 1, "b": 2, "c": 3}',
+				]
+		)
+def test_issue_10(source: str):
+	# https://github.com/domdfcoding/flake8_strftime/issues/10
+	# This shouldn't raise an exception
+	assert not list(Plugin(ast.parse(source)).run())