Update tests for flake8-pytest-style

Author: hugovk

pyproject.toml

@@ -65,33 +65,37 @@ fix = true
 lint.select = [
   "C4",     # flake8-comprehensions
   "D",      # pydocstyle
-  "E",      # pycodestyle
+  "E",      # pycodestyle errors
   "EM",     # flake8-errmsg
   "F",      # pyflakes
   "I",      # isort
   "ICN",    # flake8-import-conventions
   "ISC",    # flake8-implicit-str-concat
   "LOG",    # flake8-logging
   "PGH",    # pygrep-hooks
+  "PIE",    # flake8-pie
+  "PT",     # flake8-pytest-style
   "PYI",    # flake8-pyi
   "RUF022", # unsorted-dunder-all
   "RUF100", # unused noqa (yesqa)
   "UP",     # pyupgrade
-  "W",      # pycodestyle
+  "W",      # pycodestyle warnings
   "YTT",    # flake8-2020
 ]
 lint.ignore = [
-  "E203",  # Whitespace before ':'
-  "E221",  # Multiple spaces before operator
-  "E226",  # Missing whitespace around arithmetic operator
-  "E241",  # Multiple spaces after ','
-  "UP038", # Makes code slower and more verbose
+  "E203",   # Whitespace before ':'
+  "E221",   # Multiple spaces before operator
+  "E226",   # Missing whitespace around arithmetic operator
+  "E241",   # Multiple spaces after ','
+  "PIE790", # flake8-pie: unnecessary-placeholder
+  "UP038",  # Makes code slower and more verbose
 ]
 lint.per-file-ignores."tests/*" = [
   "D",
 ]
 lint.flake8-import-conventions.aliases.datetime = "dt"
 lint.flake8-import-conventions.banned-from = [ "datetime" ]
+lint.flake8-pytest-style.parametrize-names-type = "csv"
 lint.isort.known-first-party = [ "humanize" ]
 lint.isort.required-imports = [ "from __future__ import annotations" ]
 lint.pydocstyle.convention = "google"
@@ -103,8 +107,6 @@ max_supported_python = "3.14"
 addopts = "--color=yes"
 filterwarnings = [
   "error",
-  # https://github.com/dateutil/dateutil/issues/1314
-  "ignore:datetime.datetime.utcfromtimestamp:DeprecationWarning:dateutil.tz.tz",
 ]
 testpaths = [ "tests" ]
 

tests/test_i18n.py

@@ -89,15 +89,15 @@ def test_naturaldelta() -> None:
 
 
 @pytest.mark.parametrize(
-    ("locale", "number", "expected_result"),
-    (
+    "locale, number, expected_result",
+    [
         ("es_ES", 1000000, "1.0 millón"),
         ("es_ES", 3500000, "3.5 millones"),
         ("es_ES", 1000000000, "1.0 billón"),
         ("es_ES", 1200000000, "1.2 billones"),
         ("es_ES", 1000000000000, "1.0 trillón"),
         ("es_ES", 6700000000000, "6.7 trillones"),
-    ),
+    ],
 )
 def test_intword_plurals(locale: str, number: int, expected_result: str) -> None:
     try:
@@ -111,16 +111,16 @@ def test_intword_plurals(locale: str, number: int, expected_result: str) -> None
 
 
 @pytest.mark.parametrize(
-    ("locale", "expected_result"),
-    (
+    "locale, expected_result",
+    [
         ("ar", "5خامس"),
         ("ar_SA", "5خامس"),
         ("fr", "5e"),
         ("fr_FR", "5e"),
         ("pt", "5º"),
         ("pt_BR", "5º"),
         ("pt_PT", "5º"),
-    ),
+    ],
 )
 def test_langauge_codes(locale: str, expected_result: str) -> None:
     try:
@@ -134,16 +134,16 @@ def test_langauge_codes(locale: str, expected_result: str) -> None:
 
 
 @pytest.mark.parametrize(
-    ("locale", "number", "gender", "expected_result"),
-    (
+    "locale, number, gender, expected_result",
+    [
         ("fr_FR", 1, "male", "1er"),
         ("fr_FR", 1, "female", "1ère"),
         ("fr_FR", 2, "male", "2e"),
         ("es_ES", 1, "male", "1º"),
         ("es_ES", 5, "female", "5ª"),
         ("it_IT", 3, "male", "3º"),
         ("it_IT", 8, "female", "8ª"),
-    ),
+    ],
 )
 def test_ordinal_genders(
     locale: str, number: int, gender: str, expected_result: str
@@ -187,19 +187,17 @@ def test_default_locale_path_null__spec__(
         i18n = importlib.import_module("humanize.i18n")
         monkeypatch.setattr(i18n, "__spec__", None)
 
-        with pytest.raises(Exception) as excinfo:
+        with pytest.raises(Exception, match=self.expected_msg):
             i18n.activate("ru_RU")
-        assert str(excinfo.value) == self.expected_msg
 
     def test_default_locale_path_undefined__spec__(
         self, monkeypatch: pytest.MonkeyPatch
     ) -> None:
         i18n = importlib.import_module("humanize.i18n")
         monkeypatch.delattr(i18n, "__spec__")
 
-        with pytest.raises(Exception) as excinfo:
+        with pytest.raises(Exception, match=self.expected_msg):
             i18n.activate("ru_RU")
-        assert str(excinfo.value) == self.expected_msg
 
     @freeze_time("2020-02-02")
     def test_en_locale(self) -> None:

tests/test_time.py

@@ -755,10 +755,13 @@ def test_precisedelta_suppress_units(
 def test_precisedelta_bogus_call() -> None:
     assert humanize.precisedelta(None) == "None"
 
-    with pytest.raises(ValueError):
+    with pytest.raises(
+        ValueError,
+        match="Minimum unit is suppressed and no suitable replacement was found",
+    ):
         humanize.precisedelta(1, minimum_unit="years", suppress=["years"])
 
-    with pytest.raises(ValueError):
+    with pytest.raises(ValueError, match="Minimum unit 'years' not supported"):
         humanize.naturaldelta(1, minimum_unit="years")