Skip to content

Refactor: simplify scientific() and extract _SUPERSCRIPT_MAP constant #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hugovk merged 5 commits into from
May 14, 2026
+16 −21
Merged

Refactor: simplify scientific() and extract _SUPERSCRIPT_MAP constant #313

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
12b43e0
refactor: extract _SUPERSCRIPT_MAP constant and simplify scientific()
maayanmatsliah-tech May 14, 2026
6e297f9
Merge branch 'main' into main
hugovk May 14, 2026
af13b7e
move _SUPERSCRIPT_MAP and switch to list comprehension
maayanmatsliah-tech May 14, 2026
bf493c7
Merge branch 'main' of github.com:maayanmatsliah-tech/humanize
maayanmatsliah-tech May 14, 2026
13e54db
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 15 additions & 20 deletions src/humanize/number.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,20 @@
from .i18n import _ngettext_noop as NS_
from .i18n import _pgettext as P_

_SUPERSCRIPT_MAP = {
Comment thread
hugovk marked this conversation as resolved.
"0": "⁰",
"1": "¹",
"2": "²",
"3": "³",
"4": "⁴",
"5": "⁵",
"6": "⁶",
"7": "⁷",
"8": "⁸",
"9": "⁹",
"-": "⁻",
}

TYPE_CHECKING = False
if TYPE_CHECKING:
from typing import TypeAlias
Expand Down Expand Up @@ -415,19 +429,6 @@ def scientific(value: NumberOrString, precision: int = 2) -> str:
"""
import math

exponents = {
"0": "⁰",
"1": "¹",
"2": "²",
"3": "³",
"4": "⁴",
"5": "⁵",
"6": "⁶",
"7": "⁷",
"8": "⁸",
"9": "⁹",
"-": "⁻",
}
try:
value = float(value)
if not math.isfinite(value):
Expand All @@ -442,13 +443,7 @@ def scientific(value: NumberOrString, precision: int = 2) -> str:

part2 = re.sub(r"^\+?(\-?)0*(.+)$", r"\1\2", part2)

new_part2 = []
for char in part2:
new_part2.append(exponents[char])

final_str = part1 + " x 10" + "".join(new_part2)

return final_str
return part1 + " x 10" + "".join(_SUPERSCRIPT_MAP[char] for char in part2)
Comment thread
hugovk marked this conversation as resolved.
Outdated


def clamp(
Expand Down
Loading