Skip to content

Commit 8ee9ca5

Browse files
authored
Add check-sdist and fix missing files (#653)
1 parent 5285a58 commit 8ee9ca5

File tree

5 files changed

+30
-5
lines changed

5 files changed

+30
-5
lines changed

.github/workflows/build.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
run-tox-env:
88
strategy:
99
matrix:
10-
toxenv: [mypy, twine-check]
10+
toxenv: [mypy, twine-check, check-sdist]
1111
py: ["3.x"]
1212
include:
1313
- toxenv: py-mindeps

CHANGELOG.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ Unreleased
1717
all errors are reported but the checked filenames are no longer displayed. The
1818
list of filenames checked is now emitted at the second verbosity level (`-vv`)
1919
and above. (:issue:`648`)
20+
- `check-jsonschema`'s sdist contents are now validated with `check-sdist`, and missing
21+
files have been added.
2022

2123
0.36.2
2224
------

MANIFEST.in

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,26 @@
22

33
# data files in the distribution
44
include src/check_jsonschema/builtin_schemas/vendor/*
5+
include src/check_jsonschema/builtin_schemas/vendor/licenses/*
6+
include src/check_jsonschema/builtin_schemas/vendor/sha256/*
57
include src/check_jsonschema/builtin_schemas/custom/*.json
68

79
## Testing Requirements
810

911
# include all test files and test data files
10-
recursive-include tests *.py *.json *.yaml *.yml *.json5 *.toml
12+
recursive-include tests *.py *.json *.yaml *.yml *.json5 *.toml *.cff
1113

1214
# the test runner
1315
include tox.ini
1416

1517
# needed as a data file for the tests (several tests check integrity
1618
# against this file)
1719
include .pre-commit-hooks.yaml
20+
21+
# tools, automation, and project maintenance
22+
include CHANGELOG.rst
23+
include CONTRIBUTING.md
24+
include justfile
25+
include scripts/*.py
26+
include .coveragerc
27+
include .flake8

pyproject.toml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ docs = [
1616
"sphinx-issues<6",
1717
"furo==2025.12.19",
1818
]
19+
check-package-metadata = [
20+
"build",
21+
"twine",
22+
"check-sdist",
23+
]
1924

2025
[project]
2126
name = "check-jsonschema"
@@ -57,6 +62,9 @@ include-package-data = true
5762
where = ["src"]
5863
namespaces = false
5964

65+
[tool.check-sdist]
66+
git-only = ["RELEASING.md", ".gitignore", "docs/*"]
67+
6068
[tool.isort]
6169
profile = "black"
6270

tox.ini

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,16 +81,21 @@ commands_pre = rm -rf _build/
8181
commands = sphinx-build -d _build/doctrees -b dirhtml -W . _build/dirhtml {posargs}
8282

8383
[testenv:twine-check]
84-
description = "check the metadata on a package build"
84+
description = "check the metadata on a package build using twine"
8585
skip_install = true
86-
deps = twine
87-
build
86+
dependency_groups = check-package-metadata
8887
allowlist_externals = rm
8988
commands_pre = rm -rf dist/
9089
# check that twine validating package data works
9190
commands = python -m build
9291
twine check dist/*
9392

93+
[testenv:check-sdist]
94+
description = "check the package contents using check-sdist"
95+
skip_install = true
96+
dependency_groups = check-package-metadata
97+
commands = check-sdist --inject-junk
98+
9499
[testenv:vendor-schemas]
95100
description = "update the vendored schemas"
96101
deps = pre-commit

0 commit comments

Comments
 (0)