Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/check_jsonschema/schema_loader/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,8 @@ def _get_validator(
) -> jsonschema.protocols.Validator:
retrieval_uri = self.get_schema_retrieval_uri()
schema = self.get_schema()
if retrieval_uri is not None and "$id" not in schema:
schema = {"$id": retrieval_uri, **schema}
schema_dialect = _dialect_of_schema(schema)

# format checker (which may be None)
Expand Down
37 changes: 37 additions & 0 deletions tests/acceptance/test_local_relative_ref.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,25 @@
CASE2_PASSING_DOCUMENT = {"test": "some data"}
CASE2_FAILING_DOCUMENT = {"test": {"foo": "bar"}}

CASE3_MAIN_SCHEMA = {
"type": "object",
"properties": {
"pupils": {
"type": "array",
"items": {"$ref": "../person/person.schema.json"},
}
},
}
CASE3_PERSON_SCHEMA = {
"type": "object",
"properties": {"address": {"$ref": "../address/address.schema.json"}},
}
CASE3_ADDRESS_SCHEMA = {
"type": "object",
"properties": {"zip_code": {"type": "number"}},
}
CASE3_PASSING_DOCUMENT = {"pupils": [{"address": {"zip_code": 12345}}]}


def _prep_files(tmp_path, main_schema, other_schema_data, instance):
main_schemafile = tmp_path / "main_schema.json"
Expand Down Expand Up @@ -75,6 +94,24 @@ def test_local_ref_schema(
run_line_simple(["--schemafile", schemafile, str(doc)])


def test_nested_local_ref_schema(run_line_simple, tmp_path):
school_dir = tmp_path / "school"
person_dir = tmp_path / "person"
address_dir = tmp_path / "address"
school_dir.mkdir()
person_dir.mkdir()
address_dir.mkdir()

main_schemafile = school_dir / "school.schema.json"
main_schemafile.write_text(json.dumps(CASE3_MAIN_SCHEMA))
(person_dir / "person.schema.json").write_text(json.dumps(CASE3_PERSON_SCHEMA))
(address_dir / "address.schema.json").write_text(json.dumps(CASE3_ADDRESS_SCHEMA))
doc = school_dir / "school.example.json"
doc.write_text(json.dumps(CASE3_PASSING_DOCUMENT))

run_line_simple(["--schemafile", str(main_schemafile), str(doc)])


@pytest.mark.parametrize(
"main_schema, other_schema_data, instance, expect_err",
[
Expand Down