Skip to content

Commit 114ddd6

Browse files
Apply suggestions from code review
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
1 parent 14b761a commit 114ddd6

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/wheels-dependencies.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ function build_zlib_ng {
149149

150150
HOST_CONFIGURE_FLAGS=$ORIGINAL_HOST_CONFIGURE_FLAGS
151151

152-
if [ -n "$IS_MACOS" ] && [ -z "$IOS_SDK" ]; then
152+
if [[ -n "$IS_MACOS" ]] && [[ -z "$IOS_SDK" ]]; then
153153
# Ensure that on macOS, the library name is an absolute path, not an
154154
# @rpath, so that delocate picks up the right library (and doesn't need
155155
# DYLD_LIBRARY_PATH to be set). The default Makefile doesn't have an
@@ -164,7 +164,7 @@ function build_brotli {
164164
if [ -e brotli-stamp ]; then return; fi
165165
local out_dir=$(fetch_unpack https://github.com/google/brotli/archive/v$BROTLI_VERSION.tar.gz brotli-$BROTLI_VERSION.tar.gz)
166166
(cd $out_dir \
167-
&& cmake -DCMAKE_INSTALL_PREFIX=$BUILD_PREFIX -DCMAKE_INSTALL_LIBDIR=$BUILD_PREFIX/lib -DCMAKE_INSTALL_NAME_DIR=$BUILD_PREFIX/lib $HOST_CMAKE_FLAGS . \
167+
&& cmake -DCMAKE_INSTALL_PREFIX=$BUILD_PREFIX -DCMAKE_INSTALL_LIBDIR=$BUILD_PREFIX/lib -DCMAKE_INSTALL_NAME_DIR=$BUILD_PREFIX/lib $HOST_CMAKE_FLAGS . \
168168
&& make install)
169169
touch brotli-stamp
170170
}

0 commit comments

Comments
 (0)