Check that _EXTENSION_PLUGIN contains all registered extensions (#143)

Author: hugovk

Tests/test_file_spider.py

@@ -14,6 +14,10 @@
 TEST_FILE = "Tests/images/hopper.spider"
 
 
+def teardown_module() -> None:
+    del Image.EXTENSION[".spider"]
+
+
 def test_sanity() -> None:
     with Image.open(TEST_FILE) as im:
         im.load()

Tests/test_image.py

@@ -466,6 +466,9 @@ def test_registered_extensions_uninitialized(self) -> None:
         # Assert
         assert Image._initialized == 2
 
+        for extension in Image.EXTENSION:
+            assert extension in Image._EXTENSION_PLUGIN
+
     def test_registered_extensions(self) -> None:
         # Arrange
         # Open an image to trigger plugin registration

src/PIL/SpiderImagePlugin.py

@@ -290,9 +290,9 @@ def _save(im: Image.Image, fp: IO[bytes], filename: str | bytes) -> None:
 
 def _save_spider(im: Image.Image, fp: IO[bytes], filename: str | bytes) -> None:
     # get the filename extension and register it with Image
-    filename_ext = os.path.splitext(filename)[1]
-    ext = filename_ext.decode() if isinstance(filename_ext, bytes) else filename_ext
-    Image.register_extension(SpiderImageFile.format, ext)
+    if filename_ext := os.path.splitext(filename)[1]:
+        ext = filename_ext.decode() if isinstance(filename_ext, bytes) else filename_ext
+        Image.register_extension(SpiderImageFile.format, ext)
     _save(im, fp, filename)