Skip to content

Commit 96b898c

Browse files
committed
A couple more cleanups from code review.
1 parent 54f2334 commit 96b898c

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

.github/workflows/wheels-dependencies.sh

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,7 @@ BROTLI_VERSION=1.1.0
6262

6363
function build_pkg_config {
6464
if [ -e pkg-config-stamp ]; then return; fi
65-
# This essentially duplicates the Homebrew recipe:
66-
# https://github.com/Homebrew/homebrew-core/blob/master/Formula/p/pkg-config.rb
65+
# This essentially duplicates the Homebrew recipe
6766
ORIGINAL_CFLAGS=$CFLAGS
6867
CFLAGS="$CFLAGS -Wno-int-conversion"
6968
build_simple pkg-config 0.29.2 https://pkg-config.freedesktop.org/releases tar.gz \
@@ -108,7 +107,6 @@ function build {
108107
if [ -n "$IS_MACOS" ]; then
109108
build_simple xorgproto 2024.1 https://www.x.org/pub/individual/proto
110109
build_simple libXau 1.0.11 https://www.x.org/pub/individual/lib
111-
build_simple libXdmcp 1.1.5 https://www.x.org/pub/individual/lib
112110
build_simple libpthread-stubs 0.5 https://xcb.freedesktop.org/dist
113111
else
114112
sed s/\${pc_sysrootdir\}// $BUILD_PREFIX/share/pkgconfig/xcb-proto.pc > $BUILD_PREFIX/lib/pkgconfig/xcb-proto.pc
@@ -123,7 +121,7 @@ function build {
123121
# Homebrew versions of those libraries from /usr/local.
124122
build_simple tiff $TIFF_VERSION https://download.osgeo.org/libtiff tar.gz \
125123
--with-jpeg-include-dir=$BUILD_PREFIX/include --with-jpeg-lib-dir=$BUILD_PREFIX/lib \
126-
--disable-webp --disable-zstd --disable-libdeflate
124+
--disable-webp --disable-libdeflate --disable-zstd
127125
else
128126
build_tiff
129127
fi
@@ -134,14 +132,17 @@ function build {
134132

135133
ORIGINAL_CFLAGS=$CFLAGS
136134
CFLAGS="$CFLAGS -O3 -DNDEBUG"
135+
if [[ -n "$IS_MACOS" ]]; then
136+
CFLAGS="$CFLAGS -Wl,-headerpad_max_install_names"
137+
fi
137138
build_libwebp
138139
CFLAGS=$ORIGINAL_CFLAGS
139140

140141
build_brotli
141142

142143
if [ -n "$IS_MACOS" ]; then
143144
# Custom freetype build
144-
build_simple freetype $FREETYPE_VERSION https://download.savannah.gnu.org/releases/freetype tar.gz --without-harfbuzz
145+
build_simple freetype $FREETYPE_VERSION https://download.savannah.gnu.org/releases/freetype tar.gz --with-harfbuzz=no
145146
else
146147
build_freetype
147148
fi
@@ -175,7 +176,7 @@ if [[ -n "$IS_MACOS" ]]; then
175176
export PATH="$BUILD_PREFIX/bin:$(dirname $(which python3)):/usr/bin:/bin:/usr/sbin:/sbin:/Library/Apple/usr/bin"
176177
export CMAKE_PREFIX_PATH=$BUILD_PREFIX
177178

178-
# Link the brew command into our isolated build directory.
179+
# Ensure the basic structure of the build prefix directory exists.
179180
mkdir -p "$BUILD_PREFIX/bin"
180181
mkdir -p "$BUILD_PREFIX/lib"
181182

0 commit comments

Comments
 (0)