PERF401 and fixes

Author: hugovk

pyproject.toml

@@ -148,6 +148,7 @@ lint.select = [
   "LOG",     # flake8-logging
   "PERF101", # perflint: unnecessary-list-cast
   "PERF102", # perflint: incorrect-dict-iterator
+  "PERF401", # perflint: manual-list-comprehension
   "PGH",     # pygrep-hooks
   "PIE",     # flake8-pie
   "PT",      # flake8-pytest-style

setup.py

@@ -1078,10 +1078,10 @@ def debug_build() -> bool:
 ]
 
 files: list[str | os.PathLike[str]] = ["src/_imaging.c"]
-for src_file in _IMAGING:
-    files.append("src/" + src_file + ".c")
-for src_file in _LIB_IMAGING:
-    files.append(os.path.join("src/libImaging", src_file + ".c"))
+files.extend("src/" + src_file + ".c" for src_file in _IMAGING)
+files.extend(
+    os.path.join("src/libImaging", src_file + ".c") for src_file in _LIB_IMAGING
+)
 ext_modules = [
     Extension("PIL._imaging", files),
     Extension("PIL._imagingft", ["src/_imagingft.c"]),

src/PIL/IcnsImagePlugin.py

@@ -80,8 +80,7 @@ def read_32(
                 if byte_int & 0x80:
                     blocksize = byte_int - 125
                     byte = fobj.read(1)
-                    for i in range(blocksize):
-                        data.append(byte)
+                    data.extend([byte] * blocksize)
                 else:
                     blocksize = byte_int + 1
                     data.append(fobj.read(blocksize))

src/PIL/ImageDraw.py

@@ -597,9 +597,7 @@ def draw_text(ink: int, stroke_width: float = 0) -> None:
                 mode = self.fontmode
                 if stroke_width == 0 and embedded_color:
                     mode = "RGBA"
-                coord = []
-                for i in range(2):
-                    coord.append(int(xy[i]))
+                coord = [int(xy[i]) for i in range(2)]
                 start = (math.modf(xy[0])[0], math.modf(xy[1])[0])
                 try:
                     mask, offset = image_text.font.getmask2(  # type: ignore[union-attr,misc]

src/PIL/ImageFile.py

@@ -215,8 +215,10 @@ def get_child_images(self) -> list[ImageFile]:
             if subifd_offsets:
                 if not isinstance(subifd_offsets, tuple):
                     subifd_offsets = (subifd_offsets,)
-                for subifd_offset in subifd_offsets:
-                    ifds.append((exif._get_ifd_dict(subifd_offset), subifd_offset))
+                ifds = [
+                    (exif._get_ifd_dict(subifd_offset), subifd_offset)
+                    for subifd_offset in subifd_offsets
+                ]
         ifd1 = exif.get_ifd(ExifTags.IFD.IFD1)
         if ifd1 and ifd1.get(ExifTags.Base.JpegIFOffset):
             assert exif._info is not None

winbuild/build_prepare.py

@@ -544,11 +544,11 @@ def write_script(
 def get_footer(dep: dict[str, Any]) -> list[str]:
     lines = []
     for out in dep.get("headers", []):
-        lines.append(cmd_copy(out, "{inc_dir}"))
+        lines.append(cmd_copy(out, "{inc_dir}"))  # noqa: PERF401
     for out in dep.get("libs", []):
-        lines.append(cmd_copy(out, "{lib_dir}"))
+        lines.append(cmd_copy(out, "{lib_dir}"))  # noqa: PERF401
     for out in dep.get("bins", []):
-        lines.append(cmd_copy(out, "{bin_dir}"))
+        lines.append(cmd_copy(out, "{bin_dir}"))  # noqa: PERF401
     return lines