Run pyroma in tox -e lint instead of pytest (#9670)

Author: radarhere

.ci/install.sh

@@ -31,7 +31,6 @@ python3 -m pip install olefile
 python3 -m pip install -U pytest
 python3 -m pip install -U pytest-cov
 python3 -m pip install -U pytest-timeout
-python3 -m pip install pyroma
 # optional test dependencies, only install if there's a binary package.
 python3 -m pip install --only-binary=:all: numpy || true
 python3 -m pip install --only-binary=:all: pyarrow || true

.github/workflows/macos-install.sh

@@ -12,7 +12,6 @@ python3 -m pip install olefile
 python3 -m pip install -U pytest
 python3 -m pip install -U pytest-cov
 python3 -m pip install -U pytest-timeout
-python3 -m pip install pyroma
 # optional test dependencies, only install if there's a binary package.
 python3 -m pip install --only-binary=:all: numpy || true
 python3 -m pip install --only-binary=:all: pyarrow || true

.pre-commit-config.yaml

@@ -86,6 +86,13 @@ repos:
     hooks:
       - id: tox-ini-fmt
 
+  - repo: https://github.com/regebro/pyroma
+    rev: 5.0.1
+    hooks:
+      - id: pyroma
+        additional_dependencies: [check-manifest]
+        stages: [manual]
+
   - repo: meta
     hooks:
       - id: check-hooks-apply

Makefile

@@ -81,8 +81,6 @@ release-test:
 	python3 -m pytest Tests
 	python3 -m pip install .
 	python3 -m pytest -qq
-	python3 -m check_manifest
-	python3 -m pyroma .
 	$(MAKE) readme
 
 .PHONY: sdist

Tests/test_image_access.py

@@ -260,6 +260,7 @@ class TestEmbeddable:
     @pytest.mark.xfail(not (sys.version_info >= (3, 13)), reason="failing test")
     @pytest.mark.skipif(not is_win32(), reason="requires Windows")
     def test_embeddable(self) -> None:
+        pytest.importorskip("setuptools", reason="setuptools not installed")
         import ctypes
 
         from setuptools.command import build_ext

Tests/test_pyroma.py

@@ -63,17 +63,16 @@ optional-dependencies.test-arrow = [
   "pyarrow",
 ]
 optional-dependencies.tests = [
-  "check-manifest",
   "coverage>=7.4.2",
   "defusedxml",
   "markdown2",
   "olefile",
   "packaging",
-  "pyroma>=5",
   "pytest",
   "pytest-cov",
   "pytest-timeout",
   "pytest-xdist",
+  "setuptools",
   "trove-classifiers>=2024.10.12",
 ]
 optional-dependencies.xmp = [

pyproject.toml

@@ -29,7 +29,7 @@ pass_env =
     PREK_COLOR
 commands =
     prek run --all-files --show-diff-on-failure
-    check-manifest
+    prek run --all-files --show-diff-on-failure pyroma
 
 [testenv:mypy]
 skip_install = true