Only test register_handler in a single thread#8501
Only test register_handler in a single thread#8501radarhere wants to merge 3 commits intopython-pillow:mainfrom
register_handler in a single thread#8501Conversation
lysnikolaou
left a comment
There was a problem hiding this comment.
I've also been working on fixing some of these issues. Since you think we should leave these alone in #8492 (comment), I think we should mark the tests with @pytest.mark.parallel_threads(1) instead.
|
Is it a problem that #8518 is another idea I had. |
I'm not sure about that to be honest. I'm using |
Possible way to help #8492. Alternative to #8518
The issue has found that running a test that calls
register_handlerat the beginning, and removes the handler at the end, fails when the test is run across multiple threads.My thinking is that if it ok for
register_handlerto operate across threads, and that it doesn't need to register multiple handlers in parallel. So this PR returns early from the relevant test if it is already running in another thread.