In _dump(), use Python PPM save, instead of C#9566
Open
radarhere wants to merge 1 commit intopython-pillow:mainfrom
Open
In _dump(), use Python PPM save, instead of C#9566radarhere wants to merge 1 commit intopython-pillow:mainfrom
radarhere wants to merge 1 commit intopython-pillow:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently raises an error
_dumpuses the C levelsave_ppm()for this scenario, which doesn't support RGBA.Pillow/src/PIL/Image.py
Lines 748 to 751 in b893310
Pillow/src/libImaging/File.c
Lines 60 to 68 in b893310
However, if we consistently use Python level
save(), then it can be handled.Pillow/src/PIL/PpmImagePlugin.py
Lines 333 to 341 in b893310