feat: add validation for import-names and import-namespaces to prevent duplicates

Author: finswimmer

src/poetry/core/factory.py

@@ -15,6 +15,7 @@
 from packaging.licenses import canonicalize_license_expression
 from packaging.utils import canonicalize_name
 
+from poetry.core.exceptions import PoetryCoreError
 from poetry.core.packages.dependency import Dependency
 from poetry.core.packages.dependency_group import DependencyGroup
 from poetry.core.utils.helpers import combine_unicode
@@ -323,9 +324,25 @@ def _configure_package_metadata(
             )
             package.readmes = tuple(root / r for r in custom_readmes if r)
 
+        cls._validate_import_names(project)
+
         package.import_names = project.get("import-names")
         package.import_namespaces = project.get("import-namespaces")
 
+    @classmethod
+    def _validate_import_names(cls, project: dict[str, Any]) -> None:
+        import_names = {
+            name.split(";")[0].strip() for name in project.get("import-names", [])
+        }
+        import_namespaces = {
+            name.split(";")[0].strip() for name in project.get("import-namespaces", [])
+        }
+
+        if duplicates := import_names & import_namespaces:
+            raise PoetryCoreError(
+                f"Import names found in both import-names and import-namespaces: {', '.join(duplicates)}"
+            )
+
     @classmethod
     def _configure_entry_points(
         cls,

tests/test_factory.py

@@ -13,6 +13,7 @@
 from packaging.utils import canonicalize_name
 
 from poetry.core.constraints.version import parse_constraint
+from poetry.core.exceptions import PoetryCoreError
 from poetry.core.factory import Factory
 from poetry.core.packages.dependency import Dependency
 from poetry.core.packages.dependency_group import MAIN_GROUP
@@ -335,6 +336,40 @@ def test_create_poetry_with_import_names() -> None:
     assert package.import_namespaces == ["my_package"]
 
 
+@pytest.mark.parametrize(
+    ["namespace_name", "import_name"],
+    [
+        ("my_package", "my_package"),
+        ("my_package; private", "my_package"),
+        ("my_package  ; private", "my_package"),
+        ("my_package; private", "my_package;  private"),
+    ],
+)
+def test_create_poetry_raise_on_name_in_import_names_and_spaces(
+    namespace_name: str, import_name: str, tmp_path: Path
+) -> None:
+    content = f"""
+[project]
+name = "my-package"
+version = "1.2.3"
+description = "Some description."
+requires-python = ">=3.6"
+
+import-namespaces = ["{namespace_name}", "another_package"]
+import-names = ["{import_name}"]
+
+dependencies = []
+"""
+    pyproject = tmp_path / "pyproject.toml"
+    pyproject.write_text(content)
+
+    with pytest.raises(
+        PoetryCoreError,
+        match="Import names found in both import-names and import-namespaces: my_package",
+    ):
+        _ = Factory().create_poetry(pyproject)
+
+
 @pytest.mark.parametrize(
     "project", ["sample_project_with_groups", "sample_project_with_groups_new"]
 )