feat: add validation for import-names and import-namespaces to prevent duplicates

Author: finswimmer

src/poetry/core/factory.py

@@ -326,6 +326,25 @@ def _configure_package_metadata(
         package.import_names = project.get("import-names")
         package.import_namespaces = project.get("import-namespaces")
 
+    @classmethod
+    def _validate_import_names(
+        cls, project: dict[str, Any], result: dict[str, list[str]]
+    ) -> None:
+        if "import-namespaces" in project and len(project["import-namespaces"]) == 0:
+            result["errors"].append("import-namespaces must not be an empty array.")
+
+        import_names = {
+            name.split(";")[0].strip() for name in project.get("import-names", [])
+        }
+        import_namespaces = {
+            name.split(";")[0].strip() for name in project.get("import-namespaces", [])
+        }
+
+        if duplicates := import_names & import_namespaces:
+            result["errors"].append(
+                f"Import names found in both import-names and import-namespaces: {', '.join(duplicates)}"
+            )
+
     @classmethod
     def _configure_entry_points(
         cls,
@@ -733,6 +752,8 @@ def validate(
                 for e in validate_object(project, "project-schema")
             ]
             result["errors"] += project_validation_errors
+            cls._validate_import_names(project, result)
+
         # With PEP 621 [tool.poetry] is not mandatory anymore. We still create and
         # validate it so that default values (e.g. for package-mode) are set.
         tool_poetry = toml_data.setdefault("tool", {}).setdefault("poetry", {})

tests/test_factory.py

@@ -335,6 +335,62 @@ def test_create_poetry_with_import_names() -> None:
     assert package.import_namespaces == ["my_package"]
 
 
+@pytest.mark.parametrize(
+    ["namespace_name", "import_name"],
+    [
+        ("my_package", "my_package"),
+        ("my_package; private", "my_package"),
+        ("my_package  ; private", "my_package"),
+        ("my_package; private", "my_package;  private"),
+    ],
+)
+def test_create_poetry_raise_on_name_in_import_names_and_spaces(
+    namespace_name: str, import_name: str, tmp_path: Path
+) -> None:
+    content = f"""
+[project]
+name = "my-package"
+version = "1.2.3"
+description = "Some description."
+requires-python = ">=3.6"
+
+import-namespaces = ["{namespace_name}", "another_package"]
+import-names = ["{import_name}"]
+
+dependencies = []
+"""
+    pyproject = tmp_path / "pyproject.toml"
+    pyproject.write_text(content)
+
+    with pytest.raises(
+        RuntimeError,
+        match="Import names found in both import-names and import-namespaces: my_package",
+    ):
+        _ = Factory().create_poetry(pyproject)
+
+
+def test_create_poetry_raise_on_empty_import_namespaces(tmp_path: Path) -> None:
+    content = """
+[project]
+name = "my-package"
+version = "1.2.3"
+description = "Some description."
+requires-python = ">=3.6"
+
+import-namespaces = []
+
+dependencies = []
+"""
+    pyproject = tmp_path / "pyproject.toml"
+    pyproject.write_text(content)
+
+    with pytest.raises(
+        RuntimeError,
+        match="import-namespaces must not be an empty array",
+    ):
+        _ = Factory().create_poetry(pyproject)
+
+
 @pytest.mark.parametrize(
     "project", ["sample_project_with_groups", "sample_project_with_groups_new"]
 )