Commit 6ae3c28
authored
Fix _remove to catch EnvCommandError instead of CalledProcessError (#10740)
run_pip() wraps CalledProcessError inside EnvCommandError, so the
except CalledProcessError handler in _remove() was dead code. If
pip exited non-zero with 'not installed' in its output, the
EnvCommandError would propagate uncaught to _execute_operation,
which treats it as a fatal error and aborts the entire installation.
This matters when removing a package that was already uninstalled
externally — e.g. via pip directly — while Poetry is performing
an update.1 parent ad9ab00 commit 6ae3c28
1 file changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | 13 | | |
15 | 14 | | |
16 | 15 | | |
| |||
624 | 623 | | |
625 | 624 | | |
626 | 625 | | |
627 | | - | |
| 626 | + | |
628 | 627 | | |
629 | 628 | | |
630 | 629 | | |
| |||
0 commit comments