Skip to content

installer: validate records #10819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dimbleby wants to merge 2 commits into
base: main
Choose a base branch
from
+17 −20
Open

installer: validate records #10819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a263a3
installer 1.0
dimbleby Apr 3, 2026
0de1903
reintroduce record content validation
dimbleby Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ dependencies = [
"cleo (>=2.1.0,<3.0.0)",
"dulwich (>=0.25.0,<2)",
"fastjsonschema (>=2.18.0,<3.0.0)",
"installer (>=0.7.0,<0.8.0)",
"installer (>=1,<2)",
"keyring (>=25.1.0,<26.0.0)",
# packaging uses calver, so version is unclamped
"packaging (>=24.2)", # PEP 639 support was added in 24.2
Expand Down
5 changes: 1 addition & 4 deletions src/poetry/installation/wheel_installer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,7 @@ def enable_bytecode_compilation(self, enable: bool = True) -> None:
def install(self, wheel: Path) -> None:
with WheelFile.open(wheel) as source:
try:
# Content validation is temporarily disabled because of
# pypa/installer's out of memory issues with big wheels. See
# https://github.com/python-poetry/poetry/issues/7983
source.validate_record(validate_contents=False)
source.validate_record()
except _WheelFileValidationError as e:
self.invalid_wheels[wheel] = e.issues

Expand Down
12 changes: 6 additions & 6 deletions tests/installation/test_executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,37 +503,37 @@ def test_execute_prints_warning_for_yanked_package(
assert error.count("yanked") == 0


@pytest.mark.skip(reason="https://github.com/python-poetry/poetry/issues/7983")
def test_execute_prints_warning_for_invalid_wheels(
config: Config,
pool: RepositoryPool,
io: BufferedIO,
tmp_path: Path,
env: MockEnv,
fixture_dir: FixtureDirGetter,
) -> None:
config.merge({"cache-dir": str(tmp_path)})

executor = Executor(env, pool, config, io)

base_url = "https://files.pythonhosted.org/"
wheel1 = "demo_invalid_record-0.1.0-py2.py3-none-any.whl"
wheel2 = "demo_invalid_record2-0.1.0-py2.py3-none-any.whl"
dist_dir = fixture_dir("distributions")
return_code = executor.execute(
[
Install(
Package(
"demo-invalid-record",
"0.1.0",
source_type="url",
source_url=f"{base_url}/{wheel1}",
source_type="file",
source_url=(dist_dir / wheel1).resolve().as_posix(),
)
),
Install(
Package(
"demo-invalid-record2",
"0.1.0",
source_type="url",
source_url=f"{base_url}/{wheel2}",
source_type="file",
source_url=(dist_dir / wheel2).resolve().as_posix(),
)
),
]
Expand Down
Loading