Fix contributing guide label links#10913
Conversation
f131762 to
442ee54
Compare
|
Deploy preview for website ready!
Deployed with vercel-action |
radoering
left a comment
There was a problem hiding this comment.
This does not seem to work. See the generated preview. Maybe, the link targets have to be inline in notes. 🤷 By the way, you can also build the docs locally with the website repo.
|
Thanks, fixed in af9f0b1 by keeping the links inside the note inline and only encoding the label slash in the GitHub URL. The latest published checks are green: Detect changed files, Status, pre-commit.ci, Sourcery review, and FreeBSD. The Documentation Preview job was skipped on this follow-up push, so I do not have a refreshed preview URL to cite. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fix the contributing guide links for the
kind/questionandarea/docsGitHub labels.The label names contain
/, so the label URLs need%2Fencoding. Thekind/questionlink is kept inline inside the note shortcode so the generated website can render it correctly.Fixes #10765.
Validation
git diff --check HEAD~1..HEADkind%2Fquestionandarea%2Fdocsaf9f0b1:Detect changed files,Status,Tests / FreeBSD Status,pre-commit.ci - pr, andSourcery reviewDocumentation Previewskipped on the follow-up push